Skip to content

FutureOr<Object> should normalize to Object and other fun ways to normalize types... #40611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nshahan opened this issue Feb 13, 2020 · 0 comments
Closed

FutureOr<Object> should normalize to Object and other fun ways to normalize types... #40611

nshahan opened this issue Feb 13, 2020 · 0 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented Feb 13, 2020

Other backends have agreed to normalize FutureOr to Object. DDC should as well and possibly do more normalization from the NNBD Normalization spec.
@nshahan nshahan added web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release labels Feb 13, 2020
@nshahan nshahan self-assigned this Feb 13, 2020
dart-bot pushed a commit that referenced this issue Mar 11, 2020
@nshahan
[dartdevc] Add missing FutureOr normalization
6add414 
FutureOr<Object> --> Object
FutureOr<Object>? --> Object?

I don't believe this to be breaking because in the current SDK
nullable types do not yet exist, and we already landed the change
to normalize FutureOr of a top type. Right now Object is still
considered a top type.

Issue: #40611
Change-Id: I83cb06db9e4bca8cb9b2c041a044904eb1080d2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139031
Reviewed-by: Mark Zhou <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan