Skip to content

Available Suggestions (wrongly) class instance getters/setters #40689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Feb 19, 2020 · 5 comments
Closed

Available Suggestions (wrongly) class instance getters/setters #40689

pq opened this issue Feb 19, 2020 · 5 comments
Labels
devexp-completion Issues with the analysis server's code completion feature legacy-area-analyzer Use area-devexp instead.

Comments

@pq
Copy link
Member

pq commented Feb 19, 2020

image
@pq pq added legacy-area-analyzer Use area-devexp instead. devexp-completion Issues with the analysis server's code completion feature labels Feb 19, 2020
@pq pq self-assigned this Feb 19, 2020
@pq
Copy link
Member Author

pq commented Feb 19, 2020

Related to #40626.

@pq pq removed their assignment Feb 19, 2020
@pq
Copy link
Member Author

pq commented Feb 19, 2020

/fyi @scheglov

@scheglov scheglov self-assigned this Feb 19, 2020
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/136410

dart-bot pushed a commit that referenced this issue Feb 19, 2020
@pq
getter/setter suggestion tests
34cdc81 
See: #40689

Change-Id: I87837592d4af458583b1710190beee4672ae4cfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136408
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
dart-bot pushed a commit that referenced this issue Feb 19, 2020
@scheglov
Issue 40689. Add isStatic to available Declaration.
ff8a5df 
I did not use it yet, but filtered out all not top-level declarations
that are not CONSTRUCTOR or ENUM_CONSTANT. But isStatic might be used
if we decide to suggest static getters.

[email protected], [email protected]

Bug: #40689
Change-Id: I1c86754d9dbbc1422defc06a8fe6a47fa0bf6f98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136410
Reviewed-by: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@scheglov
Copy link
Contributor

@pq the issue of suggesting class fields / getters has been fixed. Now we don't suggest them at all :-)

If you want to add static getters, you probably can continue from here.

@scheglov scheglov removed their assignment Feb 19, 2020
@pq
Copy link
Member Author

pq commented Feb 19, 2020

Thank you!

@pq pq mentioned this issue Feb 19, 2020
Closed
@pq pq closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devexp-completion Issues with the analysis server's code completion feature legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @scheglov