Failures on "[tests/nnbd] Fork language/bool tests for weak and strong mode"

[alexmarkov]

There are new test failures on [tests/nnbd] Fork language/bool tests for weak and strong mode.

The tests

language/bool/check_weak_test RuntimeError (expected Pass)
language/bool/condition_check_weak_test RuntimeError (expected Pass)

are failing on configurations

dartdevk-weak-linux-release-chrome

In that CL I split NNBD tests to expect different exceptions if condition is null in strong mode (TypeError) and weak mode (AssertionError). The weak mode matches pre-NNBD behavior.

It looks like DDC is throwing TypeError both in strong and weak mode.

Context: https://groups.google.com/a/google.com/g/dart-nnbd-core/c/8zp4xh9kOTU/m/1rEy2_LPAQAJ

/cc @sigmundch @nshahan

[nshahan]

Related: TypeErrors are no longer AssertionErrors #40317.

[nshahan]

Spec clarification here: dart-lang/language#917

[nshahan]

I'm working on a fix.