-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
NNBDIssues related to NNBD ReleaseIssues related to NNBD Releasearea-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.vm-nnbd-sdk-completeAll new NNBD and ported NNBD tests passAll new NNBD and ported NNBD tests passweb-dev-compiler
Description
There are new test failures on [tests/nnbd] Fork language/bool tests for weak and strong mode.
The tests
language/bool/check_weak_test RuntimeError (expected Pass)
language/bool/condition_check_weak_test RuntimeError (expected Pass)
are failing on configurations
dartdevk-weak-linux-release-chrome
In that CL I split NNBD tests to expect different exceptions if condition is null in strong mode (TypeError) and weak mode (AssertionError). The weak mode matches pre-NNBD behavior.
It looks like DDC is throwing TypeError both in strong and weak mode.
Context: https://groups.google.com/a/google.com/g/dart-nnbd-core/c/8zp4xh9kOTU/m/1rEy2_LPAQAJ
/cc @sigmundch @nshahan
Metadata
Metadata
Assignees
Labels
NNBDIssues related to NNBD ReleaseIssues related to NNBD Releasearea-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.vm-nnbd-sdk-completeAll new NNBD and ported NNBD tests passAll new NNBD and ported NNBD tests passweb-dev-compiler