Skip to content

Failures on "[tests/nnbd] Fork language/bool tests for weak and strong mode" #41278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexmarkov opened this issue Mar 31, 2020 · 3 comments
Closed

Failures on "[tests/nnbd] Fork language/bool tests for weak and strong mode" #41278

alexmarkov opened this issue Mar 31, 2020 · 3 comments
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass web-dev-compiler

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on [tests/nnbd] Fork language/bool tests for weak and strong mode.

The tests

language/bool/check_weak_test RuntimeError (expected Pass)
language/bool/condition_check_weak_test RuntimeError (expected Pass)

are failing on configurations

dartdevk-weak-linux-release-chrome

In that CL I split NNBD tests to expect different exceptions if condition is null in strong mode (TypeError) and weak mode (AssertionError). The weak mode matches pre-NNBD behavior.

It looks like DDC is throwing TypeError both in strong and weak mode.

Context: https://groups.google.com/a/google.com/g/dart-nnbd-core/c/8zp4xh9kOTU/m/1rEy2_LPAQAJ

/cc @sigmundch @nshahan
@alexmarkov alexmarkov added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass labels Mar 31, 2020
@nshahan
Copy link
Contributor

nshahan commented Mar 31, 2020

Related: TypeErrors are no longer AssertionErrors #40317.

@nshahan
Copy link
Contributor

nshahan commented Apr 7, 2020

Spec clarification here: dart-lang/language#917

@nshahan nshahan self-assigned this Apr 10, 2020
@nshahan
Copy link
Contributor

nshahan commented Apr 10, 2020

I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. NNBD Issues related to NNBD Release vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @alexmarkov