Skip to content

Analyzer: Remove error for library name clash #42699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Jul 15, 2020 · 4 comments
Closed

Analyzer: Remove error for library name clash #42699

eernstg opened this issue Jul 15, 2020 · 4 comments
Assignees
@scheglov
Labels
legacy-area-analyzer Use area-devexp instead.

Comments

@eernstg
Copy link
Member

eernstg commented Jul 15, 2020 •
edited
Loading

The analyzer reports an error for the following situation:

// Library 'lib1.dart'.
library clashing.nonempty.name;

// Library 'lib2.dart'.
library clashing.nonempty.name;

// Library 'main.dart'.
import 'lib1.dart';
import 'lib2.dart';

void main() {}

This was specified as a warning, but was removed from the language specification in dart-lang/language#1083, so the analyzer should no more report this error, with or without null-safety.
@eernstg eernstg added the legacy-area-analyzer Use area-devexp instead. label Jul 15, 2020
@eernstg
Copy link
Member Author

eernstg commented Jul 15, 2020

@johnniwinther found an extra error which is very similar. Cf. dart-lang/language#1096.

@eernstg
Copy link
Member Author

eernstg commented Jul 15, 2020

dart-lang/language#1096 has now been landed, so the error for library name clashes in exports should also be eliminated.

@scheglov scheglov self-assigned this Jul 15, 2020
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/154540

@scheglov scheglov mentioned this issue Jul 15, 2020
Closed
@scheglov
Copy link
Contributor

I opened a new co19 issue dart-lang/co19#837

dart-bot pushed a commit that referenced this issue Jul 15, 2020
@scheglov
Issue 42699. Stop reporting EXPORT_DUPLICATED_LIBRARY_NAMED and IMPOR…
ef147c0 
…T_DUPLICATED_LIBRARY_NAMED.

Bug: #42699
Change-Id: Ie64405791f15a38f170206a11eabee176b6cbfad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154540
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
This was referenced Jul 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @eernstg