Skip to content

[CP][stable channel] Merge a3767f7db86a85fcd6201e9357ad47b884002b66 to stable channel (2.13) #46173

@a-siva

Description

@a-siva

commit(s) to merge: a3767f7

merge instructions: clean merge

What is the issue: Flutter AOT precompiler crashes (flutter/flutter#83094)

What is the fix: Generate non-speculative Unbox instructions for Phis

Why cherrypick: This crash was reported by a Flutter user and it is possible other Flutter users may also run into this crash. When such a crash is reported it is not obvious the crash is because of this issue and we would spend additional engineering cycles investigating the crash and narrow it down to this cause.

Risk: The change has landed in master and is in the process of being rolled into Flutter. We should wait for it to be rolled fully which I hope will happen over the weekend.

Link to original issue(s): flutter/flutter#83094

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @alexmarkov

Metadata

Metadata

Assignees

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approvemerge-to-stable

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions