Skip to content

[meta] Add TargetKind.constructor #47421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leoshusar opened this issue Oct 9, 2021 · 3 comments
Closed

[meta] Add TargetKind.constructor #47421

leoshusar opened this issue Oct 9, 2021 · 3 comments
Assignees
@srawlins
Labels
devexp-pkg-meta Issues related to package:meta legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@leoshusar
Copy link

Hi, I hope I haven't missed anything, but would it be possible to add TargetKind.constructor?

I believe there is currently no way to restrict annotation only for constructor.
@srawlins srawlins added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-meta labels Oct 10, 2021
@lrhn lrhn added the type-enhancement A request for a change that isn't a bug label Oct 11, 2021
@bwilkerson bwilkerson added legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request devexp-pkg-meta Issues related to package:meta and removed area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-meta labels Jul 18, 2022
@gmpassos
Copy link
Contributor

gmpassos commented Feb 19, 2023 •
edited
Loading

Why is there no TargetKind.constructor defined?

@srawlins

@srawlins
Copy link
Member

Someone forgot to add it, or decided it shouldn't be added.

@bwilkerson
Copy link
Member

As with most things, we took a fairly agile approach and only added the target kinds that we needed for the annotations we had already defined at that point and were planning to use TargetKind to flag.

In hindsight that might have been a mistake because there are now uses of TargetKind that we hadn't anticipated that make adding new kinds a breaking change. What we need to do at some point is to extend TargetKind to have all of the kinds that make sense so that we minimize the number of breaking changes (as opposed to adding new kinds individually). Unfortunately, I don't have a timeframe for when such a task might happen.

@pq pq mentioned this issue Aug 28, 2023
Closed
@srawlins srawlins self-assigned this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
devexp-pkg-meta Issues related to package:meta legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@srawlins @lrhn @bwilkerson @gmpassos @leoshusar