Skip to content

migrate TargetKind enum to classes #53368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Aug 28, 2023 · 3 comments
Closed

migrate TargetKind enum to classes #53368

pq opened this issue Aug 28, 2023 · 3 comments
Assignees
@pq
Labels
devexp-pkg-meta Issues related to package:meta legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Aug 28, 2023 •
edited
Loading

Follow-up from: #49796. This is required to evolve support for existing and upcoming language features and will unblock:

Background: an earlier attempt at this refactoring was reverted in 813ca7f for appearing to cause a measurable performance regression.

813339e is a trimmed down version of that attempted change; with it landed, we'll monitor any performance impact. If there is no impact we'll publish a new version of package:meta (bumping minor version) and see if any unexpected ecosystem impact shakes out.
@pq pq added legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on devexp-pkg-meta Issues related to package:meta labels Aug 28, 2023
@pq pq self-assigned this Aug 28, 2023
copybara-service bot pushed a commit that referenced this issue Aug 28, 2023
@pq
refactor TargetKind enum to class
813339e 
A trimmed down version of https://dart-review.git.corp.google.com/c/sdk/+/258200 which was reverted (https://dart-review.git.corp.google.com/c/sdk/+/268380) for (undiagnosed) performance reasons.

See: #53368


Change-Id: Iecd00a4483a4b6904b8b281eec49228620e1e943
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322981
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 5, 2023
@pq
Add changelog entry for TargetKind refactor
f064b61 
See: #53368

Change-Id: I68a8a564db8491def160da27e625779769c81154
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324264
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq pq mentioned this issue Sep 6, 2023
Closed
23 tasks
@pq
Copy link
Member Author

pq commented Sep 6, 2023

UPDATE package:meta v1.10.0 with this change has been published. Assuming no ecosystem issues shake out, we'll go ahead and start adding new TargetKinds.

@pq
Copy link
Member Author

pq commented Sep 8, 2023

8a5ddec adds the first new target kind (for extension types). We haven't published that yet so we can still back it out but it looks like this migration may be in the clear. 🤞

@pq
Copy link
Member Author

pq commented Sep 12, 2023

This feels done. If we see any issues we can reopen.

@pq pq closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-pkg-meta Issues related to package:meta legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq