Skip to content

Result of getRetainingPath should not include WeakReference #49155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
polina-c opened this issue Jun 1, 2022 · 2 comments
Closed

Result of getRetainingPath should not include WeakReference #49155

polina-c opened this issue Jun 1, 2022 · 2 comments
Assignees
@rmacnak-google @bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-service The VM Service Protocol, both the specification and its implementation

Comments

@polina-c
Copy link
Contributor

polina-c commented Jun 1, 2022

details: https://stackoverflow.com/questions/72454842/why-weakreference-is-part-of-getretainingpath
code:

sdk/runtime/vm/service.cc

Line 2481 in 1e7bc68

static void GetRetainingPath(Thread* thread, JSONStream* js) {

Blocks memory detection tool: flutter/devtools#3951
@polina-c polina-c mentioned this issue Jun 1, 2022
Closed
@polina-c polina-c changed the title getRetainingPath should not return path that includes WeakReference Result of getRetainingPath should not include WeakReference Jun 1, 2022
@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jun 1, 2022
@a-siva
Copy link
Contributor

a-siva commented Jun 1, 2022

//cc @bkonyi

@rmacnak-google rmacnak-google added the vm-service The VM Service Protocol, both the specification and its implementation label Jan 18, 2023
@polina-c
Copy link
Contributor Author

polina-c commented May 9, 2023

Fix: https://dart-review.googlesource.com/c/sdk/+/302367

copybara-service bot pushed a commit that referenced this issue May 10, 2023
@rmacnak-google
[vm, service] Account for weakness in getRetainingPath and getRetaine…
28c2491 
…dSize.

We had been treating all references as strong for these RPCs. Now weak references are skipped, but ephemeron references are still treated as strong.

TEST=ci
Bug: #49155
Change-Id: I6c4f344ce3c0df5bdbeb133a697bb26ff972f372
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302367
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmacnak-google @a-siva @polina-c @bkonyi