Skip to content

configure code generation based on enabled lints #49558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #55825
pq opened this issue Jul 28, 2022 · 1 comment
Open
Tracked by #55825

configure code generation based on enabled lints #49558

pq opened this issue Jul 28, 2022 · 1 comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-assist Issues with analysis server assists devexp-quick-fix Issues with analysis server (quick) fixes devexp-refactoring Issues with analysis server refactorings devexp-ux P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Jul 28, 2022 •
edited
Loading

Where possible, code that is generated by assists, fixes, refactorings and snippets should be idiomatic with respect to enabled lints. (For example, trailing commas should be inserted where appropriate, absolute imports preferred, var vs. final locals, etc.)
@pq pq added legacy-area-analyzer Use area-devexp instead. devexp-ux devexp-refactoring Issues with analysis server refactorings devexp-quick-fix Issues with analysis server (quick) fixes analyzer-snippet devexp-assist Issues with analysis server assists labels Jul 28, 2022
@lrhn
Copy link
Member

lrhn commented Jul 28, 2022

Agree! And double quotes for auto-added imports.

copybara-service bot pushed a commit that referenced this issue Jul 29, 2022
@pq
use codestyle options (rather than lint enablement)
1f02320 
Related to: #49558

Change-Id: Iac37649d58be88d7d26db179ac6b48958b0c1701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252980
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@keertip keertip added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Aug 1, 2022
copybara-service bot pushed a commit that referenced this issue Aug 1, 2022
@pq
migration to code_style_options
85d91f9 
More migrations to code_style_options.

See: #49558

Change-Id: I8a2e8459ea9e02b9d65a219dad3ec73080001782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252965
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@DanTup DanTup mentioned this issue Aug 22, 2022
Open
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 29, 2022
@asashour asashour mentioned this issue Oct 25, 2022
Closed
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 14, 2024
@mosuem mosuem mentioned this issue May 23, 2024
Open
26 tasks
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-assist Issues with analysis server assists devexp-quick-fix Issues with analysis server (quick) fixes devexp-refactoring Issues with analysis server refactorings devexp-ux P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pq @srawlins @keertip @lrhn @bwilkerson