[Extension type] Syntax highlighters implementation #49734
Comments
a-siva
added
the
area-tools
See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md. Inline is only detected as part of class, the spec says: > The token `inline` is not made a built-in identifier: the reserved word `class` that occurs right after `inline` serves to disambiguate the inline class declaration with a fixed lookahead.
|
Please note that this feature has been renamed: It is now the 'inline class' feature. |
itsjustkevin
changed the title
See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md. Inline is only detected as part of class, the spec says: > The token `inline` is not made a built-in identifier: the reserved word `class` that occurs right after `inline` serves to disambiguate the inline class declaration with a fixed lookahead.
See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md. Inline is only detected as part of class, the spec says: > The token `inline` is not made a built-in identifier: the reserved word `class` that occurs right after `inline` serves to disambiguate the inline class declaration with a fixed lookahead.
See dart-lang/sdk#49734 and https://github.com/dart-lang/language/blob/master/accepted/future-releases/inline-classes/feature-specification.md. Inline is only detected as part of class, the spec says: > The token `inline` is not made a built-in identifier: the reserved word `class` that occurs right after `inline` serves to disambiguate the inline class declaration with a fixed lookahead.
itsjustkevin
changed the title
|
@itsjustkevin do you have a script to create issues like this one? I was adding some items to the server list and wasn't sure whether the syntax highlighting (that doesn't come from the server) is recorded anywhere? |
|
@DanTup I need to work on that script again, it is currently broken due to some bad graphql calls but I would be happy to add the additions you mention here! This is on my todo list for the near future. |
|
Out of interest, is the script public? (I'm curious what it does/where it gets data from). I've removed the textmate grammar (the dart-syntax-highlight repo) from my changes to the servers features since it doesn't really belong there, but it'd be good to include them in your script (or manual process) for new features. I presume the script pulls the analysis server items directly from https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/doc/process/new_language_feature.md (and there isn't another copy of that list somewhere)? |
|
I would love it if the script populated the list automatically, but IIRC it's always just created an empty issue and I've been the one copying the list into the issue. |
|
@DanTup I have not even gone through that depth of inception. My script only generates the basic issues under the umbrella issues. @bwilkerson I do see value in compiling a list and further updating these template issues to have their own child issues. bootleg scripts can be viewed here 🙂. |
|
@johnpryan and @devoncarew are maintaining this for DartPad now. FYI @RedBrogdon |
Cobbling together the list from past issues:
Add support for inline classes dart-syntax-highlight#41The text was updated successfully, but these errors were encountered: