Skip to content

[Patterns] Implement feature in the CFE #49749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itsjustkevin opened this issue Aug 19, 2022 · 0 comments
Closed

[Patterns] Implement feature in the CFE #49749

itsjustkevin opened this issue Aug 19, 2022 · 0 comments
Assignees
@johnniwinther
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@a-siva a-siva added the legacy-area-front-end Legacy: Use area-dart-model instead. label Aug 19, 2022
copybara-service bot pushed a commit that referenced this issue Sep 13, 2022
@chloestefantsova
[cfe] Add WildcardBinder and ListBinder internal AST nodes
b597207 
Part of #49749

Change-Id: Ic47effd09ebb38568a9c7847e658d22f03b2d873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258806
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 14, 2022
@chloestefantsova
[cfe] Add temporary testing framework for pattern desugarings
8d5e20e 
Part of #49749

Change-Id: Ifb46078eb24b5c5288847ae95f1a0e584830335e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259180
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 22, 2022
@chloestefantsova
[cfe] Add tests for NORM on records
78dd98a 
Part of #49749

Change-Id: I7a72eeb14000823067736c8c010a83481677d9b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260521
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 28, 2022
@chloestefantsova
[cfe] Implement a desugaring for simple if-case statements
a1ee1f6 
Part of #49749

Change-Id: I38c486d4982c9dbd5515c36eb8c38cc76ff09800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265760
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 31, 2022
@chloestefantsova
[cfe] Remove MatcherVisitor and BinderVisitor interfaces
676babf 
Part of #49749

Change-Id: I586270f8da55cd0c9445f24c698c24142c357978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266630
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 31, 2022
@chloestefantsova
[cfe] Combine Matchers and Binders into Patterns
85a841e 
Part of #49749

Change-Id: I1400d854d722e8280b9d0d66c9e1630829542aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266682
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 2, 2022
@chloestefantsova
[cfe] Implement the desugaring for RelationalPattern
777d706 
Part of #49749

Change-Id: I8b1da2a3c3f25e5147a519cf3d05e3ac2e42f401
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267341
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 4, 2022
@chloestefantsova
[cfe] Add license headers to the patterns testcaes
523257a 
Part of #49749

Change-Id: I61cd83124083f2e017101be3ea020e04583023e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267600
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 4, 2022
@chloestefantsova
[cfe] Implement the desugaring for NullCheckPattern
f011262 
Additionally, fix the revealed variable declaration issues of
VariablePattern and change more remnant mentions of Matchers and
Binders.

Part of #49749

Change-Id: I8f31bb1038f29768c82e0cfa4b55bfee3e0e16c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267581
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 8, 2022
@chloestefantsova
[cfe] Implement the desugaring for ListPattern
0fbdddf 
Part of #49749

Change-Id: I3d2c35b46cdc00dbeba10cb718de80120edff0ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268260
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 10, 2022
@chloestefantsova
[cfe] Implement the desugaring for CastPattern
0e88d41 
Part of #49749

Change-Id: Ife88f1dbe6767ee60cd192adc9d5eff168ce5bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268764
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 10, 2022
@chloestefantsova
[cfe] Declare captured variables in patterns in the flow analysis
4d5d0a9 
Part of #49749

Change-Id: If58fa05aceb501fd2d0d9b9e5fff911159d4d144
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268943
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 11, 2022
@chloestefantsova
[cfe] Implement the desugaring for NullAssertPattern
b97e5b9 
Part of #49749

Change-Id: I56ac79a98eb4306daabec05d95f09bb18d248825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268961
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 22, 2022
@chloestefantsova
[cfe] Cache access to scrutinee members in pattern desugaring
414f318 
The desugaring is presented as a series of nested if-statements
interleaved with intermediate variable declarations that cache the
results of accessing the members of the scrutinee object. Among other
things, it prevents double access to a list element when checking the
pattern conditions on it and then assigning it into a variable pattern.

Part of #49749

Change-Id: I5bf0b040c44d150eacef9a727a8a66fd3a9a568d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270701
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 24, 2022
@chloestefantsova
[cfe] Desugar MapPattern
563ef79 
Part of #49749

Change-Id: Ic2b555a4384187b358e001ea29755ca14588decd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271366
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 24, 2022
@chloestefantsova
[cfe] Desugar RecordPattern
88a23c1 
Part of #49749

Change-Id: Ibe09a7de3a664323afd18e27fc8902fb6c3f4842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271361
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 24, 2022
@chloestefantsova
[cfe] Desugar BinaryPattern
8b12c0c 
Part of #49749

Change-Id: I98dd7d63c560eb4c48350c32826e51df1491d9d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271708
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@eernstg eernstg mentioned this issue Nov 30, 2022
Open
@alexmarkov alexmarkov mentioned this issue Dec 5, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Dec 20, 2022
@chloestefantsova
[cfe] Implement desugaring for simple switch statements
e724a13 
This CL doesn't cover the following features, among others.

* Guard clauses.
* Multiple patterns per case body.
* Labels.

Part of #49749

Change-Id: I8de86785c44eecbe6e2167dc7a97d9281249af3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276524
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@alexmarkov alexmarkov mentioned this issue Dec 20, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Dec 21, 2022
@chloestefantsova
[cfe] Implement desugaring of ObjectPattern for simple cases
90b799a 
This CL doesn't cover, among other, the following

* Non-class identifiers
* Some erroneous cases

Part of #49749

Change-Id: I9c6aa9194c09cc2b10b438892b26a01c260e1baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275923
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 22, 2022
@chloestefantsova
[cfe] Add desugaring of non-matching rest pattern
1f55c4c 
Closes #50797

Part of #49749

Change-Id: Ide77d1ee262f8778de7eb8743b04508ee290ee10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276940
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 23, 2022
@chloestefantsova
[cfe] Add desugaring of simple cases of pattern variable declaration
f1ce203 
The late variables aren't supported in this CL.

Part of #49749

Change-Id: Iebc50f716e3575c6dd7bce915e5e294d4c8c8363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276525
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 30, 2022
@chloestefantsova
[cfe] Desugar pattern variable assignments
9383820 
Part of #49749

Change-Id: Ibae19d0e64f023aea047b007d73f3cee9910d259
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277683
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jan 2, 2023
@chloestefantsova
[cfe] Implement desugaring of switch expressions
23c0ff5 
Part of #49749

Closes #50814

Change-Id: Ie2524c7e5a1fc1a25f392eecbf2e444c89229923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277685
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Aske Simon Christensen <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jan 2, 2023
@chloestefantsova
[cfe] Support typedefs in object patterns
628dd02 
Part of #49749

Change-Id: I0d29a875a6a0d3bac5c20309a1b4a6c8b48618f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277960
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jan 3, 2023
@chloestefantsova
[cfe] Support guard clauses in if-case statements
40a7c7c 
Part of #49749

Change-Id: I2988ba4dda65b4e54282f892fa377cffed70f25c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277984
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@alexmarkov alexmarkov mentioned this issue Feb 8, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Feb 15, 2023
@chloestefantsova
[cfe] Add basic support for if-case elements in lists
c11d12b 
Part of #49749

Change-Id: Ib5dd6d1159c09856971ed5b39b2499971044160a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282860
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 16, 2023
@chloestefantsova
[cfe] Add basic support for if-case elements in maps
1314cd0 
Part of #49749

Change-Id: Ia75f8bf80e2014f8e8ab3b204226945b9f7a9d8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283361
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 17, 2023
@chloestefantsova
[cfe] Add basic support for pattern-for statements
521fee6 
Part of #49749

Change-Id: I0c25e96cb52d34397057f65554ceae35732b9537
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283822
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 19, 2023
@chloestefantsova
[cfe] Add support for set/map disambiguation for pattern elements
89639ba 
Part of #49749

Change-Id: Idb7f8e4bd1537abbe4133e69d2e51ae6b1e96a0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283862
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 20, 2023
@chloestefantsova
[cfe] Ajust scoping for pattern variables in pattern-for statements
459010f 
Part of #49749

Change-Id: Ia5551f14b73b6ce50e8e7390f3b7995aaf5fda3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284140
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 21, 2023
@chloestefantsova
[cfe] Add support for c-style pattern-for elements in lists
3ab2dfa 
Part of #49749

Change-Id: Iafc0239535dd89d0ff4bfa99bd10cdb3978b42ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284224
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 21, 2023
@chloestefantsova
[cfe] Adjust scope of pattern variables in collection if-elements
3f6636d 
Part of #49749

Change-Id: I78a9f1cc2a5fdc483bb0c5a62c4260be7a5366ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284360
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 22, 2023
@chloestefantsova
[cfe] Add basic support for c-style pattern-for map entries
5b0dc36 
Part of #49749

Closes #51479

Change-Id: I039a2dbb6e5b7f86a6f776d673761b1f9d5d5620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284683
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 23, 2023
@chloestefantsova
[cfe] Support set/map disambiguation in pattern-for elements
6a38a69 
Part of #49749

Change-Id: I7ee8fa434522d1361dad3f81a62412256f36089b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284780
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 26, 2023
@chloestefantsova
[cfe] Remove outdated null check to allow for-in pattern entries
c8f07e6 
Part of #49749

Closes #51489

Change-Id: I1e598f8742a271e63023f95122d8166204721aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284920
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Feb 26, 2023
@chloestefantsova
[cfe] Support pattern entry-to-element conversion in type inference
574e12d 
Part of #49749

Change-Id: I5a227763225eda6a8154591fa35aa7cc66c0050a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285320
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 1, 2023
@chloestefantsova
[cfe] Implement dispatchPatternSchema
ecef1a0 
Part of #49749

Change-Id: I9fa3ad41501422990d47bc637d46cbd22fdb54fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277004
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 2, 2023
@chloestefantsova
[cfe] Account for non-pattern case heads when joining variables
2e1dfef 
Part of #49749

Change-Id: Ib7530e476c09402405d2763f1f7c29b2f29c3bdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286461
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 2, 2023
@chloestefantsova
[cfe] Account for parser recovery in const pattern arguments
b1d7d84 
Part of #49749

Change-Id: I35801c7b0c6046076c8c31e66d684445654a8573
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286480
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 6, 2023
@chloestefantsova
[cfe] Implement matchMapType for the shared analysis of patterns
874e7ee 
Part of #49749

Closes #51523

Change-Id: I4875020510246761878e71b969698cbd1baa0de0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286822
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 7, 2023
@chloestefantsova
[cfe] Support final joint variables in switch statements
82237f9 
Part of #49749

Change-Id: I741562bd37cd5f93d4a2d1ccadcb869344bc10a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286926
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 9, 2023
@chloestefantsova
[cfe] Support private field names in object patterns
615e448 
Part of #49749

Closes #51490

Change-Id: I712ad8b5aa87a27614f76da42fb10d4c9e9a03da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287740
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 9, 2023
@chloestefantsova
[cfe] Provide pre-desugaring node to flow analysis to fix promotion
b16acf4 
Part of #49749

Change-Id: I2a70518975c809f28f0d0f72f7365492ca7d6e83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287601
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 16, 2023
@chloestefantsova
[cfe] Utilize analyzePatternForIn in the CFE
21bf3b6 
Part of #49749

Change-Id: I259bb247e08542d8d5ba7785b02fd916adc28ed0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288760
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 22, 2023
@chloestefantsova
[cfe] Split ensureAssignableResult into coersion and error reporting
2eba00f 
It allows to use coersion without error reporting in the inference of
record literals, which makes the difference when the record patterns
are involved.

Closes #51587

Part of #49749

Change-Id: I64ea7e82eb3bc14d4410a47c6ed6ef278e092496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290529
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 23, 2023
@chloestefantsova
[cfe] Make pattern matching error a StateError
cfe9932 
This is the first step in adjusting the runtime error raised on a
pattern mismatch in an irrefutable context. For now, the error message
isn't specialized and doesn't reflect the nature of the mismatch.

Part of #51720

Part of #49749

Change-Id: Ie4b997a1a36e92b25f1372f4dd98941dbcc08b61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290842
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 24, 2023
@chloestefantsova
[cfe] Use StateError as the pattern matching error in assignments
628ba2a 
Part of #49749

Change-Id: I9c4fb121526ca40e5809be8f4a8a5770d551cfb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291063
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 27, 2023
@chloestefantsova
[cfe] Coerce expressions in pattern assignment and declaration RHS
f27548a 
Closes #51738

Part of #49749

Change-Id: I4d496c303b1762c7234d66436daf125e69a34316
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291068
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 30, 2023
@chloestefantsova
[cfe] Coerce operands of relational patterns
81df576 
Closes #51871

Part of #49749

Change-Id: I13a28c4849002f189ce6c14df2efaacac2ea4bf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292001
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 3, 2023
@chloestefantsova
[cfe] Report more errors on mismatching joint variables
d758cf1 
Part of #49749

Change-Id: Ie3dd75209f40681590e378138cbe2b86a5e1619f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292361
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 4, 2023
@chloestefantsova
[cfe] Report mismatching joint variables on the first use
c747272 
Closes #51929

Part of #49749

Change-Id: Ib20bdb5eb9b0b5c1e8b34cfbac6498e642350875
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292782
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 5, 2023
@chloestefantsova
[cfe] Improve error message on incomplete joint pattern variables
9f4f7fa 
Closes #51604
Closes #51962

Part of #49749

Change-Id: I9ada7a3a0194964af5c9e2afea1c2ea3ead67641
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292890
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
@johnniwinther johnniwinther removed the Epic label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-siva @itsjustkevin @johnniwinther