[CP] [vm/ffi] Fix FfiTrampolineData GC bug

[dcharkes]

Commit(s) to merge

e3e355e

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/275060

Issue Description

GC crashes with FFI trampolines, happening on all platforms in JIT mode.

What is the fix

Make the GC visit the c_signature field again.

Why cherry-pick

Users are hitting this:

• CL "[vm/ffi] Stop reifying type argument in Pointer" causes crashes at runtime #50678

Risk

low

Issue link(s)

#50678

Extra Info

cc @mkustermann

[itsjustkevin]

@mkustermann could you take a look at this cherry-pick request?

[mkustermann]

@mkustermann could you take a look at this cherry-pick request?

@itsjustkevin LGTM

[itsjustkevin]

@dcharkes cherry-pick is approved, can you go ahead and push the gerrit cl?

[dcharkes]

I'm unfamiliar with the new process, you mean +2 in Gerrit?

I'd need a +1 on the CL.

[athomas]

Yes, you need to get the CL reviewed and then land it with the CQ as if it was targeting main.

…

On Thu, 15 Dec 2022, 10:30 Daco Harkes, ***@***.***> wrote: I'm unfamiliar with the new process, you mean +2 in Gerrit? I'd need a +1 on the CL. — Reply to this email directly, view it on GitHub <#50695 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYRJB6ILDYLSMXD7QBZFFDWNLQMJANCNFSM6AAAAAAS4DQTPI> . You are receiving this because you were assigned.Message ID: ***@***.***>

[mit-mit]

@dcharkes are you still working on this?

[dcharkes]

This was merged back in december.