-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Class modifiers] Web debugging support #50735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@sigmundch is this relevant for the feature? If so, who would be the person to tackle this? |
On the VM side we implemented the ability to display this attribute for a class here |
Thanks for reaching out @itsjustkevin - @annagrin is the main contact here. |
@annagrin for my understanding, are these features part of the sdk or in a package? |
Most of it lives in the dwds package, which is outside the SDK. That said, now that devtools is linked through DEPS and released with the sdk, I'm not sure whether that adds some constraints. @annagrin - let us know to make sure we properly track whether the SDK hash can be selected prior to the support being completely landed or not. If this is not blocking, we could potentially move it to the next milestone, post the beta cutoff |
Friendly ping. |
@annagrin - anything to land here? |
Same as #51289, none of these new class attributes are currently being read by any of the debugging tools (DevTools, dap). Therefore this can be follow-up for after Dart 3.0.0. |
Thanks! @itsjustkevin - what do you think about moving these two to a 3.1 milestone? |
moving this to the cleanup milestone to be done after the 3.0 release. |
I believe the comment in #51289 states there is nothing to do at the moment but something to consider for the future if the developers tool creates the UI to display this information. considering that would make sense to treat this as the issue for tracking that feature ? |
Yes, keeping this open to track implementation on web sounds good. We haven't prioritized implementing this in DWDS because currently we aren't exposing class modifier information in any of the debugging tools. |
No description provided.
The text was updated successfully, but these errors were encountered: