Skip to content

[Class modifiers] Web debugging support #50735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsjustkevin opened this issue Dec 15, 2022 · 14 comments
Open

[Class modifiers] Web debugging support #50735

itsjustkevin opened this issue Dec 15, 2022 · 14 comments
Assignees
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-eval evaluation support on the web

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@munificent munificent changed the title [NCM] Web debugging support [Class modifiers] Web debugging support Dec 17, 2022
@lrhn lrhn added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Dec 20, 2022
@srujzs srujzs added the web-eval evaluation support on the web label Dec 20, 2022
@itsjustkevin itsjustkevin added this to the Dart 3 beta 3 milestone Feb 6, 2023
@itsjustkevin
Copy link
Contributor Author

@sigmundch is this relevant for the feature? If so, who would be the person to tackle this?

@a-siva
Copy link
Contributor

a-siva commented Mar 2, 2023

On the VM side we implemented the ability to display this attribute for a class here
https://dart-review.googlesource.com/c/sdk/+/285360
The VM service API was modified for this and I presume the dwds would have to be changed to provide the same information.

@sigmundch
Copy link
Member

Thanks for reaching out @itsjustkevin - @annagrin is the main contact here.

@itsjustkevin
Copy link
Contributor Author

@annagrin for my understanding, are these features part of the sdk or in a package?

@sigmundch
Copy link
Member

Most of it lives in the dwds package, which is outside the SDK. That said, now that devtools is linked through DEPS and released with the sdk, I'm not sure whether that adds some constraints.

@annagrin - let us know to make sure we properly track whether the SDK hash can be selected prior to the support being completely landed or not. If this is not blocking, we could potentially move it to the next milestone, post the beta cutoff

@itsjustkevin
Copy link
Contributor Author

Friendly ping.

@vsmenon
Copy link
Member

vsmenon commented Apr 4, 2023

@annagrin - anything to land here?

@vsmenon
Copy link
Member

vsmenon commented Apr 5, 2023

@annagrin @elliette - anything to do here or can we close?

@vsmenon vsmenon added the P2 A bug or feature request we're likely to work on label Apr 5, 2023
@elliette
Copy link
Contributor

elliette commented Apr 6, 2023

Same as #51289, none of these new class attributes are currently being read by any of the debugging tools (DevTools, dap). Therefore this can be follow-up for after Dart 3.0.0.

@vsmenon
Copy link
Member

vsmenon commented Apr 6, 2023

Thanks!

@itsjustkevin - what do you think about moving these two to a 3.1 milestone?

@itsjustkevin
Copy link
Contributor Author

moving this to the cleanup milestone to be done after the 3.0 release.

@eernstg
Copy link
Member

eernstg commented Apr 19, 2024

@elliette, based on 'Same as #51289' which is closed, we might be able to close this issue?

@a-siva
Copy link
Contributor

a-siva commented Apr 19, 2024

@elliette, based on 'Same as #51289' which is closed, we might be able to close this issue?

I believe the comment in #51289 states there is nothing to do at the moment but something to consider for the future if the developers tool creates the UI to display this information. considering that would make sense to treat this as the issue for tracking that feature ?

@elliette
Copy link
Contributor

I believe the comment in #51289 states there is nothing to do at the moment but something to consider for the future if the developers tool creates the UI to display this information. considering that would make sense to treat this as the issue for tracking that feature ?

Yes, keeping this open to track implementation on web sounds good. We haven't prioritized implementing this in DWDS because currently we aren't exposing class modifier information in any of the debugging tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-eval evaluation support on the web
Projects
None yet
Development

No branches or pull requests

9 participants