Skip to content

[Sealed class] Web debugging support #51289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #51278
itsjustkevin opened this issue Feb 6, 2023 · 9 comments
Closed
Tracked by #51278

[Sealed class] Web debugging support #51289

itsjustkevin opened this issue Feb 6, 2023 · 9 comments
Assignees
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-eval evaluation support on the web

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@itsjustkevin itsjustkevin added this to the Dart 3 beta 3 milestone Feb 6, 2023
@devoncarew devoncarew added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Feb 7, 2023
@nshahan nshahan added the web-eval evaluation support on the web label Feb 11, 2023
@nshahan
Copy link
Contributor

nshahan commented Feb 11, 2023

@annagrin We need to investigate if this new language feature requires any special handling on the debugger side.

@a-siva
Copy link
Contributor

a-siva commented Mar 2, 2023

On the VM side we implemented the ability to display this attribute for a class here
https://dart-review.googlesource.com/c/sdk/+/285360
The VM service API was modified for this and I presume the dwds would have to be changed to provide the same information.

@itsjustkevin
Copy link
Contributor Author

Friendly ping.

@vsmenon
Copy link
Member

vsmenon commented Apr 4, 2023

@annagrin - anything we need to land here?

@annagrin
Copy link
Contributor

annagrin commented Apr 5, 2023

I don't think so - we don't currently support any of the class attributes for web (we lack symbols). The vm_service update won't break dwds (tested the debugger with it).

@elliette do you know if class attributes are used or shown anywhere in DevTools for web or other platforms?

@elliette
Copy link
Contributor

elliette commented Apr 5, 2023

None of these class attributes are being used in DevTools or in DAP currently. This can be follow up for after Dart 3.0.0.

@itsjustkevin
Copy link
Contributor Author

Moved to the Dart 3 cleanup milestone. Thank you @elliette and @annagrin!

@leafpetersen
Copy link
Member

Anything to do here, or should we close this out?

@nshahan
Copy link
Contributor

nshahan commented May 9, 2023

At this time there is nothing related to class modifiers shown in the debug tools. I'm closing and we can create a new issue if/when the UI makes use of that information.

@nshahan nshahan closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-eval evaluation support on the web
Projects
None yet
Development

No branches or pull requests

8 participants