Skip to content

Flutter customer tests override operator == with a dynamic parameter. #51038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
srawlins opened this issue Jan 17, 2023 · 4 comments
Closed
2 of 6 tasks

Flutter customer tests override operator == with a dynamic parameter. #51038

srawlins opened this issue Jan 17, 2023 · 4 comments
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task

Comments

@srawlins
Copy link
Member

srawlins commented Jan 17, 2023 •
edited
Loading

See failures here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791703831221213185/+/u/Customer_testing/customer_testing/test_stdout

We have to fix all of these before issuing a warning about it.
@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task legacy-area-analyzer Use area-devexp instead. labels Jan 17, 2023
@srawlins srawlins mentioned this issue Jan 17, 2023
Closed
srawlins added a commit to srawlins/flutter_portal that referenced this issue Jan 17, 2023
@srawlins
== override parameters are non-nullable
ee393f1 
Make operator == override parameters no-nullable. See https://github.com/dart-lang/linter/issues/3441

Work towards dart-lang/sdk#51038.
@srawlins srawlins mentioned this issue Jan 17, 2023
Merged
srawlins added a commit to flutter/cocoon that referenced this issue Jan 17, 2023
@srawlins
== override parameters are non-nullable
7d7aa48 
Make operator == override parameters no-nullable. See dart-lang/linter#3441

Work towards dart-lang/sdk#51038.
@srawlins srawlins mentioned this issue Jan 17, 2023
Merged
8 tasks
srawlins added a commit to srawlins/flutter_reactive_ble that referenced this issue Jan 17, 2023
@srawlins
Make operator == override parameters no-nullable. See dart-lang/linte…
7a5b262 
…r#3441

Work towards dart-lang/sdk#51038.
@srawlins srawlins mentioned this issue Jan 17, 2023
Merged
@navaronbracke
Copy link

@srawlins If I'm not mistaken you should be using other is SomeType && <other checks here> instead of as?

Yes, you will get a warning from the unrelated_type_equality_checks lint but it fails at runtime with a type cast error.

@srawlins
Copy link
Member Author

I'm not sure what you're referring to. One of the PRs? Could you comment on the PR?

@srawlins srawlins mentioned this issue Jan 17, 2023
Open
@navaronbracke
Copy link

@srawlins I commented on PhilipsHue/flutter_reactive_ble#677 to clarify.

Not sure about the cast in the flutter_cocoon PR, but per flutter/cocoon#2400 (comment) I think its fine?

auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Jan 18, 2023
@srawlins
== override parameters are non-nullable (#2400)
d2e43a0 
* == override parameters are non-nullable

Make operator == override parameters no-nullable. See dart-lang/linter#3441

Work towards dart-lang/sdk#51038.

* Update fake_google_account.dart
srawlins added a commit to flutter/tests that referenced this issue Jan 18, 2023
@srawlins
Bump flutter_cocoon.test to bring analysis fix
f87dd13 
Work towards dart-lang/sdk#51038
@srawlins srawlins mentioned this issue Jan 18, 2023
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Jan 18, 2023
@srawlins
Bump flutter_portal.test to bring in analysis fix
6559578 
Work towards dart-lang/sdk#51038
@srawlins srawlins mentioned this issue Jan 18, 2023
Merged
8 tasks
Taym95 pushed a commit to PhilipsHue/flutter_reactive_ble that referenced this issue Feb 7, 2023
@srawlins
Make operator == override parameters non-nullable (#677)
e14d8d0 
* Make operator == override parameters no-nullable. See dart-lang/linter#3441

Work towards dart-lang/sdk#51038.
srawlins added a commit to flutter/tests that referenced this issue Feb 7, 2023
@srawlins
Bump flutter_cocoon.test to bring analysis fix (#210)
90a7d16 
Work towards dart-lang/sdk#51038
srawlins added a commit to flutter/tests that referenced this issue Feb 7, 2023
@srawlins
Bump flutter_portal.test to bring in analysis fix (#211)
1638426 
Work towards dart-lang/sdk#51038
srawlins added a commit to flutter/tests that referenced this issue Feb 7, 2023
@srawlins
Bump flutter_reactive_ble.test to bring analysis fix
0038ab0 
Work towards dart-lang/sdk#51038
@srawlins srawlins mentioned this issue Feb 7, 2023
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Feb 8, 2023
@srawlins
Bump flutter_reactive_ble.test to bring analysis fix (#219)
c6a200b 
Work towards dart-lang/sdk#51038
@srawlins
Copy link
Member Author

srawlins commented Feb 9, 2023

Customer tests are fixed.

@srawlins srawlins closed this as completed Feb 9, 2023
Taym95 pushed a commit to PhilipsHue/flutter_reactive_ble that referenced this issue Jul 6, 2023
@srawlins
Make operator == override parameters non-nullable (#677)
4cfae9f 
* Make operator == override parameters no-nullable. See dart-lang/linter#3441

Work towards dart-lang/sdk#51038.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @navaronbracke