Skip to content

[CP] [deps] rev dartdoc #51061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Jan 18, 2023 · 4 comments
Closed

[CP] [deps] rev dartdoc #51061

srawlins opened this issue Jan 18, 2023 · 4 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@srawlins
Copy link
Member

Commit(s) to merge

cabf333, partially

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/279320

Issue Description

Dartdoc had some regressions recently. One big one was dart-lang/dartdoc#3204, fixed in dart-lang/dartdoc#3271, released in dartdoc 6.1.5. In this bug, the up/down arrow keys navigate through the list of suggestions in the search box, but possibly out-of-order.

Also in dartdoc 6.1.5 is a fix for using the Enter key in the search field.

What is the fix

The fix was to use a flat structure for the suggestions, instead of a tree structure.

Why cherry-pick

dartdoc is used to build api.dart.dev, which would feature this bug for the docs generated for Dart 2.19.0.

Risk

low

Issue link(s)

dart-lang/dartdoc#3204

Extra Info

No response
@srawlins srawlins added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 18, 2023
@srawlins
Copy link
Member Author

CC @kevmoo

@itsjustkevin
Copy link
Contributor

I see this as low risk and high reward. I am going to approve this, does anyone disagree?

@itsjustkevin itsjustkevin added merge-to-beta cherry-pick-approved Label for approved cherrypick request labels Jan 19, 2023
@itsjustkevin
Copy link
Contributor

+1 on CL by @kevmoo

@a-siva a-siva added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label Jan 23, 2023
@athomas
Copy link
Member

athomas commented Jan 30, 2023

This is in 2.19.0 and on the beta channel.

@athomas athomas closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@srawlins @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas