-
Notifications
You must be signed in to change notification settings - Fork 125
Fix arrow key functions in search by using a flat list of suggestions #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If Flutter is keen on having this fix, it is found in dartdoc 6.1.5, cc @goderbauer @gspencergoog |
@parlough is api.dartdoc.dev really generated strictly from the |
@srawlins It looks like it is generated as part of the release infrastructure with the dartdoc in third_party/pkg: https://dart.googlesource.com/recipes/+/refs/heads/main/recipes/release/sdk.py#155 I'm not super familiar with the SDK setup or those recipes, but I guess that should be the same one as in DEPS? \cc @sortie who may know more specifics. |
@srawlins – I do believe it's based on the SDK dep. Went through this churn last time we rolled dartdoc |
CC @devoncarew RE rolling DEPS |
Yeah, the api.dart.dev documentation is built by the sdk recipe. It uses the Dart SDK that was just freshly build invoked on |
Thanks! Maybe I can cherry-pick one line in a DEPS roll CL |
Fixes #3204
The problem is that the suggestions were grouped by their container, which is useful for the main body of search.html, but not for the search box.
This code is very hard for me to understand. #3272 would improve that.