Skip to content

Fix arrow key functions in search by using a flat list of suggestions #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Dec 12, 2022

Fixes #3204

The problem is that the suggestions were grouped by their container, which is useful for the main body of search.html, but not for the search box.

This code is very hard for me to understand. #3272 would improve that.

@srawlins srawlins changed the title Fix search arrows by using a flat list of suggestions Fix arrow key functions in search by using a flat list of suggestions Dec 12, 2022
@srawlins srawlins requested a review from scheglov December 12, 2022 21:37
@srawlins srawlins merged commit 3ff7aa7 into dart-lang:master Dec 12, 2022
@srawlins srawlins deleted the fix-search-arrows branch December 13, 2022 18:26
@srawlins
Copy link
Member Author

If Flutter is keen on having this fix, it is found in dartdoc 6.1.5, cc @goderbauer @gspencergoog

@parlough
Copy link
Member

parlough commented Jan 14, 2023

@srawlins Consider cherry-picking 6.1.5 to beta if it's still possible. This also affects the SDK docs (and users who generate with dart doc) and it's a little awkward.

@srawlins
Copy link
Member Author

@parlough is api.dartdoc.dev really generated strictly from the dartdoc that is in the SDK? I hoped it was completely detached, like pub.dev is.

@parlough
Copy link
Member

parlough commented Jan 17, 2023

@srawlins It looks like it is generated as part of the release infrastructure with the dartdoc in third_party/pkg: https://dart.googlesource.com/recipes/+/refs/heads/main/recipes/release/sdk.py#155

I'm not super familiar with the SDK setup or those recipes, but I guess that should be the same one as in DEPS?

\cc @sortie who may know more specifics.

@kevmoo
Copy link
Member

kevmoo commented Jan 18, 2023

@srawlins – I do believe it's based on the SDK dep. Went through this churn last time we rolled dartdoc

@kevmoo
Copy link
Member

kevmoo commented Jan 18, 2023

CC @devoncarew RE rolling DEPS

@sortie
Copy link

sortie commented Jan 18, 2023

Yeah, the api.dart.dev documentation is built by the sdk recipe. It uses the Dart SDK that was just freshly build invoked on third_party/pkg/dartdoc/bin/dartdoc.dart to generate the dartdocs, which are then uploaded to cloud storage, which is then automatically served by api.dart.dev. Notably the documentation for older releases is not regenerated and remain as it was permanently. I hope that answers your questions :)

@srawlins
Copy link
Member Author

Thanks! Maybe I can cherry-pick one line in a DEPS roll CL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow keys do not iterate through search suggestions in order
5 participants