Skip to content

Source location jumps around a lot when stepping through patterns #51812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
derekxu16 opened this issue Mar 21, 2023 · 0 comments
Closed

Source location jumps around a lot when stepping through patterns #51812

derekxu16 opened this issue Mar 21, 2023 · 0 comments
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@derekxu16
Copy link
Member

See https://dart-review.googlesource.com/c/sdk/+/290240/3/pkg/vm_service/test/step_through_patterns_test.dart for example. Is this expected?
@derekxu16 derekxu16 added the legacy-area-front-end Legacy: Use area-dart-model instead. label Mar 21, 2023
copybara-service bot pushed a commit that referenced this issue Mar 30, 2023
@johnniwinther
[cfe] Add expectation test for file offsets
1114d0c 
In preparation for fixing #51812

Change-Id: I810be0a0330f0bf90fc1230b5a2d17f695d6e46b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292007
Reviewed-by: Jens Johansen <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 30, 2023
@alexmarkov
[vm,debugger] Do not stop at hoisted variable declarations when stepp…
103a098 
…ing through patterns

TEST=pkg/vm_service/test/step_through_patterns_test.dart
Issue: #51812
Issue: #49755

Change-Id: Ieb2e6f49c613c7543e7e76119cefbc4d8f9ae3de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291840
Commit-Queue: Alexander Markov <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
copybara-service bot pushed a commit that referenced this issue Apr 1, 2023
@johnniwinther
[cfe] Preserve offsets for uncached expression
6a4947a 
The changes the MatchingCache to always create a new CacheExpression.
When the expression is cached the first CacheExpression is used
(the current behavior) but when the expression is not cached, each
individual CacheExpression is used. This ensures the file offsets match
the source location for the uncached expression.

In the updated VM test this shows up as the is-tests using all for
lines in the switch case and not just the first two.

In response to #51812

Change-Id: I2d7bdb54e11f212cd809899a50d827284c4f6657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292082
Reviewed-by: Chloe Stefantsova <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekxu16