Skip to content

gen_snapshot and dart snapshot sometimes crash on ios flutter buildbot bot #56529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aam opened this issue Aug 20, 2024 · 3 comments
Closed

gen_snapshot and dart snapshot sometimes crash on ios flutter buildbot bot #56529

aam opened this issue Aug 20, 2024 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@aam
Copy link
Contributor

aam commented Aug 20, 2024

from https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/422092/overview logs

[1641/6217] ACTION //flutter/third_party/dart/runtime/observatory:build_observatory(//build/toolchain/mac:ios_clang_arm)
FAILED: gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js 
vpython3 ../../../flutter/third_party/dart/build/gn_run_binary.py compiled_action ../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart --dfe=../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot compile js -o gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js --packages=../../../flutter/third_party/dart/.dart_tool/package_config.json ../../../flutter/third_party/dart/runtime/observatory/web/main.dart --minify
Command failed: /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart --dfe=../../../flutter/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot compile js -o gen/flutter/third_party/dart/runtime/observatory/observatory/web/main.dart.js --packages=../../../flutter/third_party/dart/.dart_tool/package_config.json ../../../flutter/third_party/dart/runtime/observatory/web/main.dart --minify
output: 
===== CRASH =====
si_signo=Segmentation fault: 11(11), si_code=SEGV_MAPERR(1), si_addr=0x1011c5112e0
version=3.6.0-2.0.dev (dev) (Tue Jul 2 21:02:51 2024 -0700) on "macos_x64"
pid=79469, thread=4099, isolate_group=main(0x7faa8a808200), isolate=(nil)(0x0)
os=macos, arch=x64, comp=no, sim=no
isolate_instructions=114735000, vm_instructions=1082d75a0
fp=700003156dd0, sp=700003156d90, pc=1085b15ad
  pc 0x00000001085b15ad fp 0x0000700003156dd0 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x30d5ad
  pc 0x00000001085b1c49 fp 0x0000700003156e30 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x30dc49
  pc 0x00000001085b1859 fp 0x0000700003156ea0 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x30d859
  pc 0x0000000108587927 fp 0x0000700003156f20 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x2e3927
  pc 0x0000000108587bb3 fp 0x0000700003156f50 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x2e3bb3
  pc 0x0000000108507a3e fp 0x0000700003156fb0 /Volumes/Work/s/w/ir/cache/builder/src/flutter/third_party/dart/tools/sdks/dart-sdk/bin/dart+0x263a3e
  pc 0x00007ff81976818b fp 0x0000700003156fd0 _pthread_start+0x63
  pc 0x00007ff819763ae3 fp 0x000070

Seemingly related is how gen_snapshot crashes without any diagnostic.

from https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/428094/overview
logs

from https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/423461/overview logs

[4823/6580] ACTION //flutter/lib/snapshot:generate_snapshot_bin(//build/toolchain/mac:ios_clang_arm_sim)
FAILED: gen/flutter/lib/snapshot/vm_isolate_snapshot.bin gen/flutter/lib/snapshot/vm_snapshot_instructions.bin gen/flutter/lib/snapshot/isolate_snapshot.bin gen/flutter/lib/snapshot/isolate_snapshot_instructions.bin 
vpython3 ../../../build/gn_run_binary.py clang_arm64/gen_snapshot --snapshot_kind=core --enable_mirrors=false --vm_snapshot_data=/Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_sim_arm64/gen/flutter/lib/snapshot/vm_isolate_snapshot.bin --vm_snapshot_instructions=/Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_sim_arm64/gen/flutter/lib/snapshot/vm_snapshot_instructions.bin --isolate_snapshot_data=/Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_sim_arm64/gen/flutter/lib/snapshot/isolate_snapshot.bin --isolate_snapshot_instructions=/Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_sim_arm64/gen/flutter/lib/snapshot/isolate_snapshot_instructions.bin /Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_sim_arm64/flutter_patched_sdk/platform_strong.dill

[4824/6580] ACTION //flutter/third_party/dart/runtime:generate_version_cc_file(//build/toolchain/mac:clang_x64)

cc @rmacnak-google @zanderso @a-siva
@aam aam added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Aug 20, 2024
@rmacnak-google
Copy link
Contributor

Manually symbolizing the first one:

0x30d6d0 dart::MarkingVisitorBase<true>::MarkingVisitorBase
0x30de80 dart::MarkingVisitorBase<false>::MarkingVisitorBase
0x30d930 dart::MarkingVisitorBase<true>::DrainMarkingStackWithPauseChecks
0x2e3b40 dart::ThreadPool::Worker::Main
0x2e3bf0 dart::ThreadPool::OnEnterIdleLocked
0x263ac0 dart::OSThread::CreateThreadLocal

@rmacnak-google
Copy link
Contributor

Symbols might be a bit off, since DrainMarkingStackWithPauseChecks does not (even indirectly) call MarkingVisitorBase constructor.

@a-siva a-siva added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels Aug 21, 2024
@aam aam mentioned this issue Sep 4, 2024
Closed
rmacnak-google added a commit to rmacnak-google/buildroot that referenced this issue Sep 9, 2024
@rmacnak-google
Report the exit code for failed build-time executions.
9d5643c 
Bug: dart-lang/sdk#56529
@rmacnak-google rmacnak-google mentioned this issue Sep 9, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Sep 9, 2024
@rmacnak-google
[build] Report the exit code for failed build-time executions.
640724d 
Bug: #56529
Change-Id: Idc0e41091491b144c12056dca2eb441444c2af0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384400
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
rmacnak-google added a commit to flutter/buildroot that referenced this issue Sep 9, 2024
@rmacnak-google
Report the exit code for failed build-time executions. (#894)
f85c3be 
Bug: dart-lang/sdk#56529
rmacnak-google added a commit to rmacnak-google/engine that referenced this issue Sep 9, 2024
@rmacnak-google
Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e.
4e1be2f 
- Report the exit code for failed build-time executions.

Bug: dart-lang/sdk#56529
@rmacnak-google rmacnak-google mentioned this issue Sep 9, 2024
Merged
rmacnak-google added a commit to flutter/engine that referenced this issue Sep 10, 2024
@rmacnak-google
Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (#55051)
c87e6c8 
- Report the exit code for failed build-time executions.

Bug: dart-lang/sdk#56529
jesswrd pushed a commit to jesswrd/engine that referenced this issue Sep 11, 2024
@rmacnak-google @jesswrd
Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (flutter#…
4f52987 
…55051)

- Report the exit code for failed build-time executions.

Bug: dart-lang/sdk#56529
@a-siva
Copy link
Contributor

a-siva commented Oct 30, 2024

The second crash mentioned in the issue has been fixed, Closing issue, if we see the crash again please reopen.

@a-siva a-siva closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aam @rmacnak-google @a-siva