Skip to content

Implement shared native memory multithreading #56841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 tasks
mraleph opened this issue Oct 3, 2024 · 10 comments
Open
12 tasks

Implement shared native memory multithreading #56841

mraleph opened this issue Oct 3, 2024 · 10 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug

Comments

@mraleph
Copy link
Member

mraleph commented Oct 3, 2024

The Shared Memory Multithreading for Dart proposal outlines a number of modifications to the Dart native runtime and core libraries which would unlock interoperability use cases which currently require developers to writing additional native code.

These modifications include:

  • Introduction of shared fields - static fields which are shared between all isolates in a group. In shared native memory multithreading only fields containing trivially shareable objects are allowed to be marked as shared.
  • Introduction of shared isolates - each isolate group has a dedicated isolate which does not contain any isolated state. An attempt to run code in this isolate which accesses non-shared field will throw an exception.
  • API extensions to dart:ffi:
    • NativeCallable.shared

There might be other changes to core libraries which would help the cause but is not necessarily required:

  • Helpers for atomic reads and writes in dart:ffi.
  • API extensions to dart:isolate
    • Isolate.shared
    • Isolate.postTask.
    • Isolate.runSync.
  • Introduction of dart:concurrent.
    • AtomicRef, AtomicInt32, AtomicInt64
    • Mutex and Condition.

These changes do not fundamentally alter Dart's isolate model - pure Dart code running in different isolates remains isolated, but introduce more straightforward way to bridge concurrency chasm between native world (which is structured around threads) and Dart (which is structured around isolates).

@mraleph mraleph added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Oct 3, 2024
@mraleph
Copy link
Member Author

mraleph commented Oct 3, 2024

@leafpetersen @lrhn From my perspective this subset of changes does not really fundamentally change Dart language capabilities (pure Dart code remains isolated) so I would like to move forward, implement and ship this not guarded by any flag so that our interop efforts could rely on it. Any opposition to this plan?

cc @aam @a-siva @mkustermann @mit-mit

@lrhn
Copy link
Member

lrhn commented Oct 3, 2024

If you think the feature will be useful as written, then I have no problem with trying try to implement it.
It might be the only way to see if it's viable.

I'm not promising to change the implementation of platform libraries to be able to run without access to non-constant static state, or to make all such fields shared (which likely isn't viable anyway). That means that an unknown-size part of the platform libraries cannot be used in a shared isolate. I do fear that the that part might contain some essential APIs.

If all the shared isolate code does is computation on input data to produce output data, then maybe that's not a problem. Maybe it's just a matter of managing expectations.

@ClementBeal
Copy link

ClementBeal commented Oct 3, 2024

I'm very excited by this feature! I believe it would speed up a lot of code u

To visualize what would be the development of code with the shared memory, I wrote this quick sort with the shared fields and shared isolates.

Edit : Not correct. See #56841 (comment)

/**
 * Quick sort
 */

import 'dart:isolate';
import 'dart:math';
import 'dart:typed_data';

Future<void> quickSort(Int64List array, int low, int high) async {
  if (low < high) {
    int partitionIndex = partition(array, low, high);

    await Future.wait(
      [
        Isolate.runShared(
          () => quickSort(array, low, partitionIndex - 1),
        ),
        Isolate.runShared(
          () => quickSort(array, partitionIndex + 1, high),
        ),
      ],
    );
  }
}

int partition(Int64List array, int low, int high) {
  int pivot = array[high];
  int i = (low - 1);

  for (var j = low; j < high; j++) {
    if (array[j] <= pivot) {
      swap(array, ++i, j);
    }
  }

  swap(array, i + 1, high);

  return i + 1;
}

void swap(Int64List array, int i, int j) {
  final tmp = array[i];
  array[i] = array[j];
  array[j] = tmp;
}

void main() async {
  final random = Random();
  final List<int> numbers = List.generate(10000, (i) => random.nextInt(999999));
  final shared Int64List toSort = Int64List.fromList(numbers);

  Isolate.runShared(() {
    quickSort(toSort, 0, numbers.length - 1);
  });
}

I wonder if the shared keyword or the pragma (I'm not sure about it) will be passed to the function parameters like this Future<void> quickSort(shared Int64List array, int low, int high) async.

@mraleph
Copy link
Member Author

mraleph commented Oct 3, 2024

@ClementBeal

To visualize what would be the development of code with the shared memory, I wrote this quick sort with the shared fields and shared isolates.

I just want to point out a couple of things.

First of all, the type of code you have written can already be written without any issues: you can allocate memory for Int64List outside of the Dart heap and then share that between multiple isolates. Then process that concurrently.

Second, the code as written has a number of issues:

  • The proposal does not introduce shared on local variables. So it will be simply final Int64List toSort.
  • The closure you have written captures numbers which means runShared will actually throw an ArgumentError because that is not allowed.
  • The closure you have written uses async which will not work in shared isolate.

So this code is not really the best example for this feature.

@ClementBeal
Copy link

Thanks you for your explanation. I understand better now

@a-siva a-siva added triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug labels Oct 9, 2024
@venbrinoDev
Copy link

Hi @mraleph,

I’ve been working with isolates and came across an issue — well, not really an issue, but more of a question regarding how Dart handles shared memory. Specifically, I have a socket.io instance that’s spawned by a native block of code, and I was looking for a way to access the same instance across the main isolate.

Would using Shared Isolates or a shared static field help in this case? Or is my design approach flawed?

The goal is to be able to access the same SocketIo instance across different isolates. For example:

shared SocketIo instance = io();

That way, I could access this instance from any isolate. Any advice or guidance on this would be greatly appreciated!

@mraleph
Copy link
Member Author

mraleph commented Oct 11, 2024

@venbrinoDev whether or not we will allow sharing arbitrary mutable objects between isolate is still not fully decided. The first step we are planning to make - shared native memory - will not help you, because Socket1 is a full fledged mutable Dart object, it can't be made trivially shareable.

Here is a question: why do you have two isolates both connecting the server? what is the second isolate doing?

If you really need it, then you need to design this in a different way: one isolate creates and maintains the connection and all other isolates need to communicate with that isolate using ports. One isolate becomes kinda like a proxy for a connection. (Unfortunately Dart isolates don't facilitate this sort of thinking because they are designed as a coarse grained fork of the whole program).

Footnotes

  1. I assume you are using this package: https://github.com/rikulo/socket.io-client-dart

@nguyenhothanhtam0709
Copy link

Are there currently any working on this?

@mraleph
Copy link
Member Author

mraleph commented Dec 9, 2024

@aam is working on this.

@nguyenhothanhtam0709
Copy link

@mraleph , thanks for your response. Hope to see this feature in Dart soon.

copybara-service bot pushed a commit that referenced this issue May 5, 2025
Allow dart code execution on mutator thread, do not require an isolate.

It moves some states that was kept on an isolate to thread or isolate group.

Bug: #54530
Bug: #56841

TEST=run_isolate_group_run_test

CoreLibraryReviewExempt: only internal library is being updated
Change-Id: I99df09e23954755387ea6230bfd166493d78e989
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418503
Reviewed-by: Slava Egorov <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 6, 2025
…ic fields.

Sample snapshot size comparison before/after:

===
dart2js_aot.dart.snapshot before: 19946368
                          after:  19998800  (with flag turned on)
                          delta:     52432 0.26%
===

Bug: #54530
Bug: #56841
CoreLibraryReviewExempt: internal library change only
Change-Id: I34b1945c040bbad22cb3ec6fdb6e6776df31a82f
TEST=run_isolate_group_run_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422360
Reviewed-by: Alexander Markov <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 6, 2025
This method allows for synchronous execution of dart callbacks from native code. The execution happens on dart mutator thread, from which dart code can only access isolate-group variables - those which are tagged with .

Bug: #54530
Bug: #56841
Change-Id: Ia1a6b01327be493f003f1eea82e558bb6b147dd3
CoreLibraryReviewExempt: only internal library change
TEST=isolate_group_shared_callback_test
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422920
Reviewed-by: Slava Egorov <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants