Linter features for Flutter code

[Hixie]

Flutter adds to the Dart style guide with:

https://github.com/flutter/engine/blob/master/sky/specs/style-guide.md

Many things in that list could be caught by a linter (or a code reformatter), such as:

• Never use var.
• Always type everything explicitly except arguments named _, __, ___, etc.
• Don't use _ arguments.
• Never use as.
• Constructors always come first.
• Default (unnamed) constructor should come first among the constructors.
• Whitespace inside {}, [], () blocks should be symmetric at the start and end. (i.e. If a block starts with a newline, it ends with a newline. If it starts with two, it ends with two. If it starts with a space, it ends with a space. And so on.)
• Don't call super if you have no arguments to pass up to the superclass.
• Always put the body of an if on its own line.
• Avoid braces around one-line code blocks (e.g. in if statements) unless there's a chain (with else) and one of the elements in the chain has a multi-line block. we've decided to be lax about this
• Use a switch when examining an enum, not an if chain or ?: operator.
• Only use => if both sides fit on the same line or if the expression is a single constructor call.

[pq]

For reference, the wrapper bits we want to do away with (formerly skyanalyzer) are now here.

[pq]

@Hixie : closing for staleness. Feel free to re-open or harvest into a fresh ticket.

Thanks!

[Hixie]

I don't understand. In what sense is it stale?

(I can't reopen.)

[pq]

Sorry, too brash. I was meaning possibly not up to date and maybe superseded by individual issues. Happy to keep it open. 👍

[Hixie]

I've updated the list slightly but it's mostly still the same as before.

[pq]

Awesome thanks!

it's mostly still the same as before.

(Though that is a little sad.)

[pq]

See also: flutter/website#1985.