Rule avoid_type_to_string not working

The rule avoid_type_to_string is not working for me.

Here are the steps to reproduce:

dart --version
Dart SDK version: 2.12.3 (stable) (Wed Apr 14 11:02:39 2021 +0200) on "windows_x64"
dart create --template package-simple example_lib
Replace content of analysis_options.yaml with the following:

linter:
  rules:
    avoid_type_to_string: true

Append the following to lib/example_lib.dart:

class A {}

void f() {
  A().runtimeType.toString();
}

dart analyze
Expected result: a message regarding avoid_type_to_string
Actual result: no issues found

@a14n

/fyi @a14n

I was just running into this as well, the BAD example given in the docs [1] also doesn't produce any lints:

void bar(Object other) {
  if (other.runtimeType.toString() == 'Bar') {   // LINT expected
    doThing();
  }
}

Object baz(Thing myThing) {
  return getThingFromDatabase(key: myThing.runtimeType.toString());   // LINT expected
}

// ---

void doThing() {

}

Object getThingFromDatabase({String? key}) {
  return 'Foo';
}

class Thing {

}

[1] https://dart-lang.github.io/linter/lints/avoid_type_to_string.html

@a14n

@a14n: any thoughts?

@pq

@pq I'm not the author of this lint ;)

@nscobie

Sorry! I was confused w/ no_runtimeType_toString! 😬 Apologies!

Looks like that one was a contribution from @nscobie (dart-archive/linter#2209). They're on to other stuff though so we'll likely have to look at it.

Hi all, sorry to hear this lint is having issues.

I can definitely repro this not working with dart analyze using Dart SDK version 2.12.3, as reported.

However, it does appear to still be working on my end when running dart test -N avoid_type_to_string in this repository.

When testing in this repository, it successfully reports all violations for the current test cases, the BAD example listed in the docs, and the repro case reported in this issue.
This holds true for both the current HEAD (commit de386a3), and linter version 0.1.129 (the one used in Dart SDK 2.12.3).

Could this be an issue with rolling into/configuring in the SDK/analyzer? I am not at all familiar with that process, or the overall interplay between the SDK and linter packages.

Unfortunately I won't have much availability to help with this until my exams are over in a few weeks.

FWIW this issue still applies - this lint never finds any violations, as far as I see.

Also not working on my side with Dart 3.6.0

[web_ui] Fix avoid_type_to_string lint violation (#184342)

ignore avoid_type_to_string lint rule

This change just ignores existing violations of avoid_type_to_string,…

[web_ui] Fix avoid_type_to_string lint violation (flutter#184342)

ignore avoid_type_to_string lint rule in flutter_tools (#184766)

ignore avoid_type_to_string lint rule (flutter#184765)

[web_ui] Fix avoid_type_to_string lint violation (#184342)

Navigation Menu

Repository navigation

Rule avoid_type_to_string not working #58377

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Rule avoid_type_to_string not working #58377

Description

Activity

pq commented on Apr 21, 2021

goderbauer commented on Apr 26, 2021

pq commented on Apr 26, 2021

a14n commented on Apr 26, 2021

pq commented on Apr 26, 2021

nscobie commented on Apr 27, 2021

oprypin commented on Nov 22, 2022

jv-soares commented on Mar 13, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions