Skip to content

[macros] support for one_member_abstracts #59432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #59399
pq opened this issue Apr 10, 2024 · 3 comments
Closed
Tracked by #59399

[macros] support for one_member_abstracts #59432

pq opened this issue Apr 10, 2024 · 3 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Apr 10, 2024

No description provided.

@pq pq mentioned this issue Apr 10, 2024
Open
@pq pq self-assigned this Apr 10, 2024
@pq pq changed the title [macros] evaluate support for one_member_abstracts [macros] support for one_member_abstracts Apr 10, 2024
@pq pq added P2 A bug or feature request we're likely to work on linter-new-language-feature labels Apr 11, 2024
copybara-service bot referenced this issue Apr 11, 2024
@pq
one_member_abstracts support for augmented classes
2782a48 
Fixes: https://github.com/dart-lang/linter/issues/4924

Change-Id: Ib51ba2dbbb4c4c27a582606b988ed42b4f5260ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362191
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq
Copy link
Member Author

pq commented Apr 11, 2024

Implemented w/ 2782a48.

@pq pq closed this as completed Apr 11, 2024
@pq pq reopened this May 8, 2024
@pq
Copy link
Member Author

pq commented May 8, 2024

Library augmentation support is implemented but we also don't want to overreport on macro classes (which are forbidden from being abstract).

copybara-service bot referenced this issue May 8, 2024
@pq
don't report one_member_abstracts on macro classes
14be3fb 
Completes: https://github.com/dart-lang/linter/issues/4924

Change-Id: I27095ed1dd07c8c9662776d83c5dbfc8fd478e64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365900
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
@pq
Copy link
Member Author

pq commented May 8, 2024

Completed w/ 14be3fb.

@pq pq closed this as completed May 8, 2024
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew