Type checking is broken #6
Comments
|
This comment was originally written by [email protected] Just to be more clear, test.py —checked should turn on the type checks. Support was only added a few days ago. A fresh build and Ben got them to work in as much as they are supported. Added Invalid label. |
|
This comment was originally written by [email protected] Added Accepted label. |
|
This comment was originally written by [email protected] bool foo(bool bar()) => bar(); bool baz() => true; main() { When run with --enable_type_checks, this should produce no errors, but instead I get: $ dart --enable_type_checks /tmp/foo3.dart V8 execution returned non-zero exit-code: 1 Set owner to [email protected]. |
|
This comment was originally written by [email protected] Set owner to [email protected]. |
|
This comment was originally written by [email protected] I have a fix I will be landing today that addresses this. |
|
This comment was originally written by [email protected] Sorry, jat. I assumed that a patch was not forth coming. Assigned back to you. Set owner to [email protected]. |
|
This comment was originally written by [email protected] JAT, I believe that your commit, http://code.google.com/p/dart/source/detail?r=975 fixed this issue. Please reopen if that is not the case. Added Fixed label. |
See: b/374689139. https://dart-review.googlesource.com/c/sdk/+/390941 is blocking an SDK roll. Root cause: ``` Action threw an exception: type 'ConstructorMember' is not a subtype of type 'ConstructorFragment' in type cast #0 InterfaceTypeImpl.constructors2.<anonymous closure> (package:analyzer/src/dart/element/type.dart:569) #1 MappedListIterable.elementAt (dart:_internal/iterable.dart:435) #2 ListIterator.moveNext (dart:_internal/iterable.dart:364) #3 new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189) #4 new _GrowableList.of (dart:core-patch/growable_array.dart:150) #5 new List.of (dart:core-patch/array_patch.dart:39) #6 ListIterable.toList (dart:_internal/iterable.dart:224) #7 InterfaceTypeImpl.constructors2 (package:analyzer/src/dart/element/type.dart:570) #8 _Visitor._hasConstConstructorInvocation (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:110) #9 _Visitor.visitConstructorDeclaration (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:58) ``` To verify the fix locally: ``` solo_test_X() async { await assertNoErrorsInCode(r''' class A<T> {} '''); var A = findElement.class_('A').instantiate( typeArguments: [intType], nullabilitySuffix: NullabilitySuffix.none, ); A.constructors2; } ``` Bug: b/374689139 Change-Id: I70034d938d840dc0c3939db27e7116164e4617e9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391483 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
This test has a few independent calls to asyncExpectThrows which uses asyncStart/asyncEnd. However, multiple top-level asyncStart/asyncEnd are not allowed, which causes the following flaky error: ``` Unhandled exception: Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test. #0 asyncStart (package:expect/async_helper.dart:53) #1 asyncExpectThrows (package:expect/async_helper.dart:140) #2 testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/tests/standalone/io/http_auth_digest_test.dart:345) #3 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951) #4 Future._propagateToListeners (dart:async/future_impl.dart:980) #5 Future._completeWithValue (dart:async/future_impl.dart:723) #6 Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807) #7 _microtaskLoop (dart:async/schedule_microtask.dart:40) #8 _startMicrotaskLoop (dart:async/schedule_microtask.dart:49) #9 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:128) #10 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:195) --- Re-run this test: python3 tools/test.py -n vm-aot-ubsan-linux-release-x64 standalone/io/http_auth_digest_test ``` This change attempts to fix this by adding a top-level asyncStart/asyncEnd and also asyncStart/asyncEnd to the server start/shutdown to enclose each test case into asyncStart/asyncEnd and avoid printing "unittest-suite-success" marker before all test cases are finished. TEST=standalone/io/http_auth_digest_test Change-Id: I950e7c6c09f5c2144da874ab3be3cd3a130d3790 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411086 Commit-Queue: Alexander Markov <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
This is an attempt to fix flaky failure ``` Unhandled exception: Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test. #0 asyncStart (package:expect/async_helper.dart:53) #1 asyncExpectThrows (package:expect/async_helper.dart:140) #2 testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///C:/b/s/w/ir/tests/standalone/io/http_auth_test.dart:263) #3 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951) #4 Future._propagateToListeners (dart:async/future_impl.dart:980) #5 Future._completeWithValue (dart:async/future_impl.dart:723) #6 Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807) #7 _microtaskLoop (dart:async/schedule_microtask.dart:42) #8 _startMicrotaskLoop (dart:async/schedule_microtask.dart:60) #9 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:127) #10 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194) --- Re-run this test: python3 tools/test.py -n vm-aot-win-release-x64 standalone/io/http_auth_test ``` The test has multiple calls to asyncExpectThrows which uses asyncStart/asyncEnd, but only one top-level asyncStart/asyncEnd is allowed. In addition to a top-level asyncStart/asyncEnd, also add asyncStart/asyncEnd around creation and shutdown of the server in order to make sure all test cases are completed before test is finished. TEST=standalone/io/http_auth_test Change-Id: Ibb55dbae2c2e48e18f51f9a0adc24101d6121a8c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425600 Reviewed-by: Brian Quinlan <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
This issue was originally filed by [email protected]
Use dartc_test to run:
bool foo(bool bar()) => bar();
bool bar() {}
main() {
foo(bar);
}
with --enable_type_checks.
An error is thrown because the type of bar is not bool.
The text was updated successfully, but these errors were encountered: