Repository navigation
lib/typed_data/float32x4_clamp_test fails on vm-linux-debug-simriscv64 #64546
Copy link
Copy link
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.gardening
Description
╰─➤ python3 tools/test.py -n vm-linux-debug-simriscv64 lib/typed_data/float32x4_clamp_test
-- WARNING --
The provided named configuration does not match the host system or architecture:
vm-linux-debug-simriscv64
Passing the `--detect-host` flag will modify the named configuration to match the local system and architecture.
No build targets found.
Test configuration:
vm-linux-debug-simriscv64(architecture: simriscv64, compiler: dartk, mode: debug, runtime: vm, system: linux)
Suites tested: lib
FAILED: dartk-vm debug_simriscv64 lib/typed_data/float32x4_clamp_test
Expected: Pass
Actual: RuntimeError
--- Command "vm_compile_to_kernel" (took 182ms):
DART_CONFIGURATION=DebugSIMRISCV64 pkg/vm/tool/gen_kernel --no-aot --platform=out/DebugSIMRISCV64/vm_platform.dill -o out/DebugSIMRISCV64/generated_compilations/vm-linux-debug-simriscv64/tests_lib_typed_data_float32x4_clamp_test/out.dill tests/lib/typed_data/float32x4_clamp_test.dart -Dtest_runner.configuration=vm-linux-debug-simriscv64 --packages=.dart_tool/package_config.json
exit code:
0
--- Command "vm" (took 423ms):
DART_CONFIGURATION=DebugSIMRISCV64 TEST_COMPILATION_DIR=out/DebugSIMRISCV64/generated_compilations/vm-linux-debug-simriscv64/tests_lib_typed_data_float32x4_clamp_test out/DebugSIMRISCV64/dart --optimization-counter-threshold=10 --no-background-compilation -Dtest_runner.configuration=vm-linux-debug-simriscv64 --ignore-unrecognized-flags --packages=.dart_tool/package_config.json out/DebugSIMRISCV64/generated_compilations/vm-linux-debug-simriscv64/tests_lib_typed_data_float32x4_clamp_test/out.dill
exit code:
255
stderr:
Unhandled exception:
Expect.equals(expected: <0>, actual: <1>) fails.
#0 Expect._fail (package:expect/expect.dart:992:5)
#1 Expect._failNotEqual (package:expect/expect.dart:184:5)
#2 Expect.equals (package:expect/expect.dart:161:5)
#3 expectLanes (file:///usr/local/google/home/aam/p/d/d2/sdk/tests/lib/typed_data/float32x4_clamp_test.dart:45:10)
#4 testZeroClamp (file:///usr/local/google/home/aam/p/d/d2/sdk/tests/lib/typed_data/float32x4_clamp_test.dart:69:3)
#5 main (file:///usr/local/google/home/aam/p/d/d2/sdk/tests/lib/typed_data/float32x4_clamp_test.dart:91:5)
#6 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:313:19)
#7 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12)
--- Re-run this test:
python3 tools/test.py -n vm-linux-debug-simriscv64 lib/typed_data/float32x4_clamp_test
[00:00 | 100% | + 0 | - 1]
=== 0 tests passed, 1 failed ===
Started with https://dart-review.googlesource.com/c/sdk/+/549060
cc @modulovalue
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.gardening
Activity
aam commentedon Oct 9, 2026
test was updated to verify clamping of 0 to [-1, -0] to be -0, uses min(max) now. But riscv min/max implementation uses float comparison
feqswhich considers +0 and -0 to be equal.cc @rmacnak-google
modulovalue commentedon Oct 9, 2026
I’ll take a look.
modulovalue commentedon Oct 11, 2026
cl/562661
[vm, compiler] Fold Float32x4/Float64x2 min and max with Dart semantics