frog build relies on release build being present #668
Labels
closed-duplicate
Closed in favor of an existing report
P0
A serious issue requiring immediate resolution
Comments
|
cc @dgrove. |
iposva-google
added
Type-Defect
P0
copybara-service bot
pushed a commit
that referenced
this issue
Jun 8, 2022
…ions) https://dart.googlesource.com/protobuf/+log/b149f801cf7a..408f69b98b2d 2022-06-08 [email protected] Update documentation according to Effective Dart documentation guide (#664) 2022-06-02 [email protected] Move closures in proto3 deserializer to top-level (#668) 2022-06-02 [email protected] Refactor protobuf bench runners, update README: (#665) 2022-06-02 [email protected] Benchmarks: add proto3 ser/deser benchs, move common code to common.dart (#667) 2022-06-02 [email protected] Remove makeLongInt helper (#666) 2022-05-31 [email protected] Use `-O4` when compiling benchmarks. (#552) 2022-05-25 [email protected] Remove invalid check in `_FieldSet.writeFieldValue` (#660) 2022-05-20 [email protected] Refactor file locations, update READMEs (#657) 2022-05-19 [email protected] Remove trailing whitespace in protoc_plugin/README If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-protobuf-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I0f1aa66ee6fe167f37443957234f4d0140828416 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247467 Reviewed-by: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The build scripts rely on unbuilt stuff. Just building --mode=debug will fail with this message:
PhaseScriptExecution "Action "generate_frogsh"" /Sources/dart-all/dart/xcodebuild/dart-frog.build/Debug_ia32/frogsh.build/Script-095A7D91DE56B603C848FB82.sh
cd /Sources/dart-all/dart/frog
/bin/sh -c /Sources/dart-all/dart/xcodebuild/dart-frog.build/Debug_ia32/frogsh.build/Script-095A7D91DE56B603C848FB82.sh
note: Generating frogsh file
Dart VM not built. Please run the following command:
../tools/build.py -m release
Command /bin/sh failed with exit code 1
Command /bin/sh failed with exit code 1
This is broken on many levels, as you rebuild debug in will keep using an out-of-date Dart VM binary. This build needs to honor the current(!) build mode.
The text was updated successfully, but these errors were encountered: