Skip to content

Object.defineProperty not supported in Opera (and IE9 when it goes into "quirks mode") #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
efortuna opened this issue Dec 3, 2011 · 3 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request

Comments

@efortuna
Copy link
Contributor

efortuna commented Dec 3, 2011

Opera does not support Object.defineProperty, which we use in basically every compilation of Dart->JS code generated through Frog.

IE 9 also has this problem, unless you turn quirks mode off (which it seems to like to default to with our JavaScript).

They throw an error to the effect of "object does not support "Object.defineProperty" function.

Some initial web searches suggest defining defineGetter and defineSetter are a workaround to defineProperty.

@DartBot
Copy link

DartBot commented Dec 5, 2011

This comment was originally written by [email protected]


The current Dart to JavaScript compiler targets only ES5 capable browsers.

Using non-standard tricks like defineGetter won't always be able to emulate the ES5 features (e.g., defineGetter or proto doesn't work in any version of IE).

Whether IE is in compatability mode or not depends on the HTML DOCTYPE element, so it's not something that can be controlled by the script.

@DartBot
Copy link

DartBot commented Dec 5, 2011

This comment was originally written by [email protected]


Added Triaged label.

@efortuna
Copy link
Contributor Author

Opera 12 alpha correctly supports Object.defineProperty. Opera 12 will be our first Opera-supported browser.


Added WontFix label.

@efortuna efortuna added Type-Defect P3 A lower priority bug or feature request labels Dec 15, 2011
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 15, 2022
…ions)

https://dart.googlesource.com/protobuf/+log/408f69b98b2d..3105588b8e51

2022-06-15 [email protected] Remove unused function
2022-06-15 [email protected] Simplify PbList implementation, fix freezing (#626)
2022-06-15 [email protected] Remove frozen message modification handling (#643)
2022-06-15 [email protected] Bump version number for development, add changelog entry for #644
2022-06-15 [email protected] Remove ReadonlyMessageMixin (#644)
2022-06-15 [email protected] Release protobuf-2.1.0, protoc_plugin-20.0.1 (#677)
2022-06-14 [email protected] Specify `GeneratedMessage operator==` argument type (#675)
2022-06-14 [email protected] Add changes since the last protobuf release to CHANGELOG (#619)
2022-06-10 [email protected] Tweak consts.dart docs (#674)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-protobuf-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: If0f2beb1f63ef9a7527abaa116d883ef0fd4b6c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248620
Commit-Queue: Nate Bosch <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

3 participants