Update CHANGELOG.md for 1.23 strong mode changes #29183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did this as a pull request for easier previewing/editing. |
5 tasks
mit-mit
reviewed
Mar 28, 2017
| @@ -25,6 +25,56 @@ | |||
| characters to the console on Windows. Calls to `Stdout.add*()` behave as | |||
| before. | |||
|
|
|||
| ### Strong Mode | |||
There was a problem hiding this comment.
I think the last few releases has had these under the top ###Language section, with the individual changes then calling out if they are strong mode specific or not?
There was a problem hiding this comment.
But maybe this is different as these are semantic changes to existing language constructs?
There was a problem hiding this comment.
ah that's a fair point! thoughts @leafpetersen ?
There was a problem hiding this comment.
SGTM, I had the same thought.
|
Chatted with Leaf, he suggested I merge this then he'll combine with his other 1.23 language changes. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.