Add support for @Unsafe to analyzer #40431
Conversation
| @@ -2392,6 +2392,9 @@ class ElementAnnotationImpl implements ElementAnnotation { | |||
| /// The name of the top-level variable used to mark a class as being sealed. | |||
| static const String _SEALED_VARIABLE_NAME = "sealed"; | |||
|
|
|||
| /// The name of the top-level variable used to mark a method as unsafe. | |||
There was a problem hiding this comment.
Is this just methods or other members?
There was a problem hiding this comment.
nit: Unsafe is a class, not a variable.
| @@ -1,3 +1,6 @@ | |||
| ## 0.39.6 | |||
There was a problem hiding this comment.
I think this should be 0.39.5?
/cc @stereotype441
There was a problem hiding this comment.
Yeah, I am not sure what -dev means....
| @@ -2392,6 +2392,9 @@ class ElementAnnotationImpl implements ElementAnnotation { | |||
| /// The name of the top-level variable used to mark a class as being sealed. | |||
| static const String _SEALED_VARIABLE_NAME = "sealed"; | |||
|
|
|||
| /// The name of the top-level variable used to mark a method as unsafe. | |||
There was a problem hiding this comment.
nit: Unsafe is a class, not a variable.
| @@ -2540,6 +2543,12 @@ class ElementAnnotationImpl implements ElementAnnotation { | |||
| element.name == _SEALED_VARIABLE_NAME && | |||
| element.library?.name == _META_LIB_NAME; | |||
|
|
|||
| @override | |||
| bool get isUnsafe => | |||
| element is PropertyAccessorElement && | |||
There was a problem hiding this comment.
This seems wrong to me. I would have expected that it would be a ClassElement.
There was a problem hiding this comment.
Hint: I don't know what I am doing :-) So thanks for all the help!
I have not setup my environment to test this yet. When the annotation is agreed upon and pushed to master, I can tinker with this.
|
Closing this PR as there's a better proposal being discussed. |
Add support for
@Unsafeannotation asisUnsafeandhasUnsafe.See: #40429 for the definition of the annotation.