Skip to content

feat: support superscope search in later initializer. #43156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: support superscope search in later initializer. #43156

wants to merge 1 commit into from

Conversation

lfkdsk
Copy link
Contributor

@lfkdsk lfkdsk commented Aug 24, 2020 •
edited
Loading

@lfkdsk lfkdsk mentioned this pull request Aug 24, 2020
Closed
@johnniwinther
Copy link
Member

Thanks for the pull request! I've created a gerrit CL for it and made some modifications: https://dart-review.googlesource.com/c/sdk/+/159842

dart-bot pushed a commit that referenced this pull request Aug 25, 2020
@johnniwinther
[cfe] Support superscope search in late initializer
991f877 
From #43156

Closes #43137

Change-Id: I1ab972b93ee1d7b957c48d4097ff71fc1f1c5453
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159842
Reviewed-by: Dmitry Stefantsov <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
@johnniwinther
Copy link
Member

This PR has landed as https://dart.googlesource.com/sdk/+/991f877e53d76e8ba5c400dddcb338d86e98aaaf

dart-bot pushed a commit that referenced this pull request Aug 25, 2020
@johnniwinther
Revert "[cfe] Support superscope search in late initializer"
a3e001d 
This reverts commit 991f877.

Reason for revert: Breaks code using implicit this in assert initializer (which probably is illegal, though).

Original change's description:
> [cfe] Support superscope search in late initializer
> 
> From #43156
> 
> Closes #43137
> 
> Change-Id: I1ab972b93ee1d7b957c48d4097ff71fc1f1c5453
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159842
> Reviewed-by: Dmitry Stefantsov <[email protected]>
> Commit-Queue: Johnni Winther <[email protected]>

[email protected],[email protected]

Change-Id: I32ac4b4311aae3bebe31060af5e481c60d052aeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160067
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
@lfkdsk
Copy link
Contributor Author

lfkdsk commented Aug 25, 2020

https://dart-review.googlesource.com/c/sdk/+/159842
I've submitted this PR before to add active search logic to later field reference's parent class, is this PR a viable solution?

dart-bot pushed a commit that referenced this pull request Aug 25, 2020
@johnniwinther
[cfe] Reland: Support superscope search in late initializer
f61cab8 
From #43156

The reland allows this access in assert initializers.

Closes #43137

Change-Id: Ie557108a57612f0d2e838ff9420f1bb6ce0a37f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160069
Reviewed-by: Dmitry Stefantsov <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkdsk @johnniwinther @googlebot