Update documentation for countdown behavior #62145
Conversation
Clarify behavior of countdown and onTimeout function.
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/465580 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
@feinstein could you address reviewers comments on the CL in Gerrit? Otherwise please close PR if you are not planning to work on this. |
|
@mraleph sure, thanks for letting me know, I don't think I got an email about it |
|
https://dart-review.googlesource.com/c/sdk/+/465580 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/465580 has been updated with the latest commits from this pull request. |
| /// No new countdown is started when a countdown completes | ||
| /// and the [onTimeout] function is called, even if events are emitted. | ||
| /// and the [onTimeout] function is called, even if events are emitted by the | ||
| /// [EventSink] provided to [onTimeout]. The countdown is only restarted when |
There was a problem hiding this comment.
I think "emitted by" would be more precise as "added to" or even "emitted by the returned stream by [onTimeout] through the [eventSink]".
There was a problem hiding this comment.
Sorry @lrhn I don't get where specifically you want me to change the wording, I already have "emitted by" in there.
3 participants
Clarify behavior of countdown and
onTimeoutfunction.The current documentation is ambiguous and sounds like once we get a timeout, no further timeouts will ever be emitted, which is not the case for the actual code we have.