Skip to content

[linter] add documentation for specify_nonobvious_local_variable_types#63125

Open
IldySilva wants to merge 1 commit intodart-lang:mainfrom
IldySilva:linter/specify_nonobvious_local_variable_types
Open

[linter] add documentation for specify_nonobvious_local_variable_types#63125
IldySilva wants to merge 1 commit intodart-lang:mainfrom
IldySilva:linter/specify_nonobvious_local_variable_types

Conversation

@IldySilva
Copy link
Copy Markdown
Contributor

contributes to Contributes to dart-lang/site-www#7210

@copybara-service
Copy link
Copy Markdown

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/493240

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@IldySilva IldySilva changed the title Add documentation for specify_nonobvious_local_variable_types [linter] add documentation for specify_nonobvious_local_variable_types Apr 6, 2026
@copybara-service
Copy link
Copy Markdown

https://dart-review.googlesource.com/c/sdk/+/493240 has been updated with the latest commits from this pull request.

@copybara-service
Copy link
Copy Markdown

CL has new comments, please view and respond to them in Gerrit.

If a reviewer requested changes, push new commits to this PR and it will be automatically copied to Gerrit. After that you can mark reviewer comments as resolved in Gerrit and request another round of reviews.

Note: when you add comments in Gerrit they only become visible after you send them by clicking Reply and Send.

@copybara-service
Copy link
Copy Markdown

Gerrit CL has been approved, please wait for a reviewer to merge it.

There are also new comments on the CL, please review them and respond if necessary because reviewer might have requested clarifications or possibly some final changes and will not merge the CL until their questions have been answered.

@keertip
Copy link
Copy Markdown
Contributor

keertip commented Apr 15, 2026

@IldySilva , take a look at the comments on the CL

Comment thread pkg/linter/messages.yaml
stable: "3.11"
categories: [style]
hasPublishedDocs: false
hasPublishedDocs: true
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hasPublishedDocs: true
hasPublishedDocs: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants