Add deprecation hints & new/const removal to /dart-2 #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chalin
reviewed
Jul 21, 2018
| @@ -75,6 +76,8 @@ from either Dart 1.x or an earlier version of Dart 2. | |||
| * Do manual testing, and look for console errors. | |||
| Consider adding automated tests to catch issues that you find. | |||
| 7. **Fix issues until your code works.** | |||
| 8. _Optional:_ **Remove `new` and unnecessary `const`.** You can do this | |||
| by hand or use a tool such as `dartfmt --fix`. | |||
There was a problem hiding this comment.
Do we want to mention somewhere these two new lints:
- http://dart-lang.github.io/linter/lints/unnecessary_new.html
- http://dart-lang.github.io/linter/lints/unnecessary_const.html
cc @pq
There was a problem hiding this comment.
I should update https://www.dartlang.org/guides/language/analysis-options (and perhaps other places, as well) to feature those, so I plan to do that in a separate PR later today.
Are we good to go with this PR?
chalin
approved these changes
Jul 23, 2018
This was referenced Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the last unnecessary use of <2.0.0 for an SDK constraint.
Staged:
https://kw-staging-dartlang-2.firebaseapp.com/dart-2#general-process
https://kw-staging-dartlang-2.firebaseapp.com/tools/pub/dependencies#caret-syntax
Fixes #1001.