Migrate to null-safety #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #493
jakemac53
reviewed
Mar 17, 2021
| @@ -26,7 +26,7 @@ Stream<String> normalizeGeneratorOutput(Object value) { | |||
| return e.trim(); | |||
| } | |||
|
|
|||
| throw _argError(e); | |||
| throw _argError(e as Object); | |||
There was a problem hiding this comment.
I would just do a whereType<Object>() above instead of the explicit null check and cast.
There was a problem hiding this comment.
whereType doesn't exist on Stream! That's what I did first!
CC @lrhn
There was a problem hiding this comment.
Oh it does in stream_transform I think, if we don't already depend on it though then this is fine.
|
PTAL @jakemac53 |
jakemac53
approved these changes
Mar 17, 2021
|
@kevmoo When can we expect a stable release with this change? |
|
We're running some internal tests first. Maybe my end-of-day if we're lucky!
…On Thu, Mar 18, 2021 at 3:14 AM Lasse Rosenow ***@***.***> wrote:
@kevmoo <https://github.com/kevmoo> When can we expect a stable release
with this change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCVR2YIC2L6UV7XSZN3TEHG7DANCNFSM4ZJOTVDQ>
.
|
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493