Skip to content

Failing windows tests on 3.4.0 #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakemac53 opened this issue Jun 10, 2024 · 0 comments · Fixed by #2244
Closed

Failing windows tests on 3.4.0 #2243

jakemac53 opened this issue Jun 10, 2024 · 0 comments · Fixed by #2244
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jakemac53
Copy link
Contributor

See failures here https://github.com/dart-lang/test/actions/runs/9452121663/job/26034666073?pr=2242.

Cannot copy file to 'C:\Users\RUNNER~1\AppData\Local\Temp\dart_test.kernel.4322a797\output.dill', path = 'C:\Users\runneradmin\AppData\Local\Temp\dart_test_fac3c362\.dart_tool\test\incremental_kernel.

There is some issue when trying to copy over the incremental dill file. Notably there is a missing hash after the incremantal_kernel.. This could happen if the package config fails to find the root package (see https://github.com/dart-lang/test/blob/master/pkgs/test_core/lib/src/runner/package_version.dart#L21).

I am not sure if this is the core issue, but it could be related.
@jakemac53 jakemac53 added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Jun 10, 2024
This was referenced Jun 10, 2024
Merged
Closed
jakemac53 added a commit that referenced this issue Jun 10, 2024
@jakemac53
fix windows failures (#2244)
329c6df 
Fixes #2243 by not creating files that end in a `.`.

https://gist.github.com/jakemac53/845b60847dbda53f93aeed8056d5fbd2 illustrates what I think is the core of the issue. I would expect this to print false and also hit the catch block for every case. However, on 3.4.0, in the very first case the copy actually succeeds even though it claims the file doesn't exist. I filed dart-lang/sdk#55972 about this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try to fix windows failures dart-lang/test
1 participant
@jakemac53