Skip to content

expectLater returns futures that are created in another zone than the calling zone #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hixie opened this issue May 9, 2018 · 1 comment
Closed

expectLater returns futures that are created in another zone than the calling zone #830

Hixie opened this issue May 9, 2018 · 1 comment

Comments

@Hixie
Copy link
Contributor

Hixie commented May 9, 2018

If you call expectLater in a FakeAsync zone and trigger one of the codepaths that returns the precached _emptyFuture, the test will hang then time out, because of the way zones work.
Hixie added a commit to Hixie/test that referenced this issue May 9, 2018
@Hixie
Use a new future instead of a cached future from another zone
ede86d6 
As far as I can tell the comment doesn't make sense -- you don't pay the microtask hit unless you await the future.

Fixes dart-lang#830
@Hixie Hixie mentioned this issue May 9, 2018
Merged
@grouma
Copy link
Member

grouma commented May 9, 2018

Hmm this sounds awfully related to dart-lang/sdk#32556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hixie @grouma