Flexible Coverage API #1151
Merged
Flexible Coverage API #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Jan 22, 2020
| String coveragePath, LiveSuiteController controller) async { | ||
| var suite = controller.liveSuite.suite; | ||
| var coverage = await controller.liveSuite.suite.gatherCoverage(); | ||
| final outfile = File(p.join('$coveragePath', |
There was a problem hiding this comment.
coveragePath is already a string, skip the '$'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #36
Update
deserializeSuiteto take an optional callback for coverage collection. Note that each platform e.g. VM, Browser etc. makes use of this helper. This sets the foundation for per platform custom coverage collection logic.