Repository navigation
Add language version comments to bootstrap files - #1240
Merged
Merged
Conversation
Contributor
Author
|
Ok I pushed some tests here, I opted for integration tests that rely on the CFE error about having non-opted in libraries in strong mode which seems pretty reliable long term. |
Contributor
Author
|
Note that a lot of other tests are failing now, I am going to start looking into that. I think its mostly integration tests getting opted in due to not having a language version default. This is just failing through |
natebosch
approved these changes
May 20, 2020
| test.stdout, | ||
| containsInOrder([ | ||
| 'Unable to spawn isolate:', | ||
| 'Error: A library can\'t opt out of non-nullable by default, when in nnbd-strong mode.' |
Member
There was a problem hiding this comment.
Is this our message, or is it coming from somewhere else?
cc @kevmoo - how important is it that our user facing messages use "sound" instead of "strong"?
Contributor
Author
There was a problem hiding this comment.
This is likely originating from the CFE.
jakemac53
added a commit
that referenced
this pull request
May 20, 2020
This starts getting web tests compiling through the test runner, if used in combination with #1240. However I see some late initialization errors that need to be tracked down still, can follow up with that later.
jakemac53
added a commit
that referenced
this pull request
Jun 16, 2020
- Adds a nullable `languageVersionComment` field to `Metadata` - Adds a utility to get a language comment that matches the root packages version - Adds explicit language version comments to all bootstrap files ensuring the versions matches that of the test (note this assumes tests live in the root package) - Clean up the handling of serving bootstrap dart files in the browser platform which had diverged and was serving the wrong content.
jakemac53
added a commit
that referenced
this pull request
Jun 16, 2020
- Adds a nullable `languageVersionComment` field to `Metadata` - Adds a utility to get a language comment that matches the root packages version - Adds explicit language version comments to all bootstrap files ensuring the versions matches that of the test (note this assumes tests live in the root package) - Clean up the handling of serving bootstrap dart files in the browser platform which had diverged and was serving the wrong content.
jakemac53
added a commit
that referenced
this pull request
Jun 16, 2020
* Add language version comments to bootstrap files (#1240) - Adds a nullable `languageVersionComment` field to `Metadata` - Adds a utility to get a language comment that matches the root packages version - Adds explicit language version comments to all bootstrap files ensuring the versions matches that of the test (note this assumes tests live in the root package) - Clean up the handling of serving bootstrap dart files in the browser platform which had diverged and was serving the wrong content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
languageVersionCommentfield toMetadataCloses #1236
I am not sure of the proper way to test this exactly, suggestions welcome. I manually tested the vm stuff and it seems to work correctly in terms of opting in/out of strong mode.