Normalize Compact and Expanded reporters #1325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #1311
The
Compact
andExpanded
reporters have a lot of code in common,along with many superficial, and a few not-superficial differences. Some
of the impactful differences look like they may be bugs. Make it easier
to understand both reporters and their differences by reducing the
superficial changes.
The JSON reporter shares less code with the others, but aim for a
consistent field ordering there as well.
Configuration.current
from the compact reporter. Thiswas never added in the expanded reporter to avoid a transitive import
to
dart:io
. The pattern of being configured at construction isalready baked in to the
ReporterFactory
typedef and is a more clearpattern than reading from a magic zone scoped variable. Add required
constructor args for the compact reporter which match those in the
expanded reporter. Remove the TODO.
future we will likely want to migrate to
package:io
for these.reporters.
_lastProgressPassed
to avoid making it nullable._printPath
and_printPlatform
fields in the compact reporterrather than read them lazily through the zone scoped configuration.
defaults which are never used.