Skip to content

Make testRandomizeOrderingSeed public on Engine #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2021
Merged

Make testRandomizeOrderingSeed public on Engine #1543

merged 3 commits into from
Jun 17, 2021

Conversation

natebosch
Copy link
Member

One internal reporter needs this information.

@natebosch
Make testRandomizeOrderingSeed public on Engine
45b126b 
One internal reporter needs this information.
@natebosch natebosch requested a review from jakemac53 June 16, 2021 21:56
@google-cla google-cla bot added the cla: yes label Jun 16, 2021
natebosch added 2 commits June 16, 2021 14:57
@natebosch
Consistent named argument name
2e710ca 
An earlier local iteration of my change included a rename that I backed
out everywhere except for this named argument.
@natebosch
This.
2f1e968
@kevmoo
Copy link
Member

kevmoo commented Jun 17, 2021

Is this now public public? Changelog entry?

@natebosch
Copy link
Member Author

Is this now public public? Changelog entry?

Not really. It has a lib/src/ import internally. When I have time to revisit #1311 I'm hoping to drop the usage and make this class fully internal.

@natebosch natebosch merged commit eb1155c into master Jun 17, 2021
@natebosch natebosch deleted the public-ordering-seed branch June 17, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natebosch @kevmoo @jakemac53