Stop putting suite loads into active test #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #1311 Removes a UX concern from `Engine` which no longer needs to worry about how a reporter might display information about load suites. Makes the interaction between the engine and reporters less subtle. Use the term "suite load" over "load test" to start pushing terminology away from conflating tests and loading.
jakemac53
reviewed
Sep 30, 2021
This corresponds to the logic removed from `Engine` where load suites were only added to `active` when it was empty. https://github.com/dart-lang/test/blob/05d7dd11d2ce72ed168f2107bc10f056fa6f6239/pkgs/test_core/lib/src/runner/engine.dart#L452-L453
jakemac53
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1311
Removes a UX concern from
Enginewhich no longer needs to worry abouthow a reporter might display information about load suites. Makes the
interaction between the engine and reporters less subtle.
Use the term "suite load" over "load test" to start pushing terminology
away from conflating tests and loading.