Allow running tests by line and column

pkgs/test/CHANGELOG.md

@@ -1,9 +1,13 @@
 ## 1.19.0-dev
 
-* Support query parameters `name` and `full-name` on test paths, which will
-  apply the filters to only those test suites.
+* Support query parameters `name`, `full-name`, `line`, and `col` on test paths,
+  which will apply the filters to only those test suites.
   * All specified filters must match for a test to run.
   * Global filters (ie: `--name`) are also still respected and must match.
+  * The `line` and `col` will match if any frame from the test trace matches
+    (the test trace is the current stack trace where `test` is invoked).
+    * If either `line` or `col` are used, stack trace chaining is enabled for
+      that suite, regardless of the global setting.
 * Give a better exception when using `markTestSkipped` outside of a test.
 
 ## 1.18.2

pkgs/test/README.md

@@ -173,17 +173,31 @@ description (including any group descriptions) match that regular expression
 will be run. You can also use the `-N` flag to run tests whose names contain a
 plain-text string.
 
-Alternatively, you can filter tests by name only for a specific file/directory
-by specifying a query on a path: `dart test "path/to/test.dart?name=test name"`.
-That ensures that the name filters applies to one path but not others.
-
 By default, tests are run in the Dart VM, but you can run them in the browser as
 well by passing `dart test -p chrome path/to/test.dart`. `test` will take
 care of starting the browser and loading the tests, and all the results will be
 reported on the command line just like for VM tests. In fact, you can even run
 tests on both platforms with a single command: `dart test -p "chrome,vm"
 path/to/test.dart`.
 
+### Test Path Queries
+
+Some query parameters are supported on test paths, which allow you to filter the
+tests that will run within just those paths.
+
+- **name**: Works the same as `--name` (simple contains check).
+  - This is the only option that supports more than one entry.
+- **full-name**: Requires an match for the name of the test.
+- **line**: Matches any test that originates from this line in the test suite.
+  - Not supported for browser tests.
+- **col**: Matches any test that originates from this column in the test suite.
+  - Not supported for browser tests.
+
+**Example Usage**: `dart test "path/to/test.dart?line=10&col=2"`
+
+These filters are merged with any global options that are passed, and all
+filters must match for a test to be ran.
+
 ### Sharding Tests
 Tests can also be sharded with the `--total-shards` and `--shard-index` arguments,
 allowing you to split up your test suites and run them separately. For example,

pkgs/test/test/runner/line_and_col_test.dart

@@ -0,0 +1,319 @@
+// Copyright (c) 20121, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+@TestOn('vm')
+
+import 'package:test_descriptor/test_descriptor.dart' as d;
+
+import 'package:test_core/src/util/exit_codes.dart' as exit_codes;
+import 'package:test/test.dart';
+
+import '../io.dart';
+
+void main() {
+  group('with test.dart?line=<line> query', () {
+    test('selects test with the matching line', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+          test("b", () => throw TestFailure("oh no"));
+          test("c", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=6']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('selects multiple tests on the same line', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {}); test("b", () {});
+          test("c", () => throw TestFailure("oh no"));
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=4']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+2: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('selects groups with a matching line', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          group("a", () {
+            test("b", () {});
+          });
+          group("b", () {
+            test("b", () => throw TestFailure("oh no"));
+          });
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=4']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('No matching tests', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=1']);
+
+      expect(
+        test.stderr,
+        emitsThrough(contains('No tests were found.')),
+      );
+
+      await test.shouldExit(exit_codes.noTestsRan);
+    });
+
+    test('allows the line anywhere in the stack trace', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void runTest(String name) {
+          test(name, () {});
+        }
+
+        void main() {
+          runTest("a");
+          test("b", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=8']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+  });
+
+  group('with test.dart?col=<col> query', () {
+    test('selects single test with the matching column', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+            test("b", () => throw TestFailure("oh no"));
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?col=11']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('selects multiple tests starting on the same column', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+          test("b", () {});
+            test("c", () => throw TestFailure("oh no"));
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?col=11']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+2: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('selects groups with a matching column', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          group("a", () {
+            test("b", () {});
+          });
+            group("b", () {
+              test("b", () => throw TestFailure("oh no"));
+            });
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?col=11']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('No matching tests', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?col=1']);
+
+      expect(
+        test.stderr,
+        emitsThrough(contains('No tests were found.')),
+      );
+
+      await test.shouldExit(exit_codes.noTestsRan);
+    });
+
+    test('allows the col anywhere in the stack trace', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void runTest(String name) {
+          test(name, () {});
+        }
+
+        void main() {
+            runTest("a");
+          test("b", () => throw TestFailure("oh no"));
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?col=13']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+  });
+
+  group('with test.dart?line=<line>&col=<col> query', () {
+    test('selects test with the matching line and col', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});test("b", () => throw TestFailure("oh no"));
+          test("b", () => throw TestFailure("oh no"));
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=4&col=11']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+1: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('selects group with the matching line and col', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          group("a", () {
+            test("b", () {});
+            test("c", () {});
+          });
+          group("d", () {
+            test("e", () => throw TestFailure("oh no"));
+          });
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=4&col=11']);
+
+      expect(
+        test.stdout,
+        emitsThrough(contains('+2: All tests passed!')),
+      );
+
+      await test.shouldExit(0);
+    });
+
+    test('no matching tests - col doesnt match', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=4&col=1']);
+
+      expect(
+        test.stderr,
+        emitsThrough(contains('No tests were found.')),
+      );
+
+      await test.shouldExit(exit_codes.noTestsRan);
+    });
+
+    test('no matching tests - line doesnt match', () async {
+      await d.file('test.dart', '''
+        import 'package:test/test.dart';
+
+        void main() {
+          test("a", () {});
+        }
+      ''').create();
+
+      var test = await runTest(['test.dart?line=1&col=11']);
+
+      expect(
+        test.stderr,
+        emitsThrough(contains('No tests were found.')),
+      );
+
+      await test.shouldExit(exit_codes.noTestsRan);
+    });
+  });
+}

pkgs/test/test/utils.dart

@@ -227,6 +227,8 @@ SuiteConfiguration suiteConfiguration(
         BooleanSelector? excludeTags,
         Map<BooleanSelector, SuiteConfiguration>? tags,
         Map<PlatformSelector, SuiteConfiguration>? onPlatform,
+        int? line,
+        int? col,
 
         // Test-level configuration
         Timeout? timeout,
@@ -250,6 +252,8 @@ SuiteConfiguration suiteConfiguration(
         excludeTags: excludeTags,
         tags: tags,
         onPlatform: onPlatform,
+        line: line,
+        col: col,
         timeout: timeout,
         verboseTrace: verboseTrace,
         chainStackTraces: chainStackTraces,