-
Notifications
You must be signed in to change notification settings - Fork 219
Support running tests by absolute file: uri #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he path component when extracting it
ready for another review @natebosch |
You probably know this, but I think if you use |
@jakemac53 it's not urgent, but so I know when to come back to the Flutter side of this, what's the process for it getting into the Dart SDK? If it's just a case of updating the revision in DEPs I'm happy to send a CL for that, but if there's a process/schedule (or you want to get other changes in with it) I'm happy to wait. |
It should just be updating the revision in DEPs, I think it might happen automatically now also but I am not sure. Usually we would wait until we publish as well but we probably could publish soon, cc @natebosch |
We also will want to validate these changes internally first |
Okey, I'll hold off doing anything for a little bit. If you do roll it in (or notice it done automatically) and remember, let me know. Otherwise I'll check back in a little while :-) |
Fixes #1891
Fixes #1899
For any path which looks like it has a scheme (contains "://"), parse it as a uri and grab the path from that. On windows, we also remove any leading
/
from the path because it will be followed by a drive letter, which we want to be the first part of the path (and not preceded by a/
).Open to better ideas here too, if you have them :)