Experiment with disallowing subject chaining #1895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the return value from `nest` and `nestAsync`, for passing the nested condition ahead of time. This interacts really poorly with `has`. We should only consider doing this if we can find a workaround to allow inference for `has` or if we expect that the vast majority of users will use codegen and we can hide it from them. I do like how this eliminates the `which` calls for some async expectations.
Add a `HasCheck` class which only has a `which` method. Since `has` is annotated with `useResult` this method must be called (or some other awkward workaround like assigning to a variable)
natebosch
commented
Feb 2, 2023
| @@ -19,7 +19,8 @@ extension StringChecks on Subject<String> { | |||
| }); | |||
| } | |||
|
|
|||
| Subject<int> get length => has((m) => m.length, 'length'); | |||
| void hasLengthWhich(Condition<int> lengthCondition) => | |||
There was a problem hiding this comment.
We would probably also add
void hasLength(int expectedLength) {
|
#1896 does this for only async nesting |
|
#2073 (comment) shows a use case for assigning a I don't think we should make this change. I think in practice the distinction between sync and async expectations is not a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the return value from
nestandnestAsync, for passing thenested condition ahead of time.
This interacts really poorly with
has. We should only consider doingthis if we can find a workaround to allow inference for
hasor if weexpect that the vast majority of users will use codegen and we can hide
it from them.
I do like how this eliminates the
whichcalls for some asyncexpectations.