Skip to content

Remove the matcher export from test_api #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ dependencies:
webkit_inspection_protocol: ^1.0.0
yaml: ^3.0.0
# Use an exact version until the test_api and test_core package are stable.
test_api: 0.5.3
test_api: 0.6.0
test_core: 0.5.3
# Use a tight version constraint to ensure that a constraint on matcher
# properly constrains all features it provides.
matcher: '>=0.12.15 <0.12.16'
matcher: '>=0.12.16 <0.12.17'

dev_dependencies:
fake_async: ^1.0.0
Expand Down
4 changes: 3 additions & 1 deletion pkgs/test_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## 0.5.3-wip
## 0.6.0-wip

* Remove the `package:test_api/expect.dart' library. `test` will export from
`package:matcher` directly.
* Fix compatibility with wasm number semantics.

## 0.5.2
Expand Down
5 changes: 0 additions & 5 deletions pkgs/test_api/lib/expect.dart

This file was deleted.

5 changes: 0 additions & 5 deletions pkgs/test_api/lib/src/expect/async_matcher.dart

This file was deleted.

2 changes: 0 additions & 2 deletions pkgs/test_api/lib/test_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,5 @@
'Please use package:test.')
library test_api;

export 'package:matcher/expect.dart';

export 'hooks.dart' show TestFailure;
export 'scaffolding.dart';
6 changes: 1 addition & 5 deletions pkgs/test_api/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_api
version: 0.5.3-wip
version: 0.6.0-wip
description: >-
The user facing API for structuring Dart tests and checking expectations.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test_api
Expand All @@ -18,10 +18,6 @@ dependencies:
string_scanner: ^1.1.0
term_glyph: ^1.2.0

# Use a tight version constraint to ensure that a constraint on matcher
# properly constrains all features it provides.
matcher: '>=0.12.15 <0.12.16'

dev_dependencies:
analyzer: '>=2.1.0 <6.0.0'
fake_async: ^1.2.0
Expand Down
2 changes: 0 additions & 2 deletions pkgs/test_core/lib/test_core.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@
library test_core;

export 'package:test_api/hooks.dart' show TestFailure;
// Not yet deprecated, but not exposed through focused libraries.
export 'package:test_api/test_api.dart' show registerException;

export 'scaffolding.dart';
4 changes: 1 addition & 3 deletions pkgs/test_core/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ dependencies:
stream_channel: ^2.1.0
vm_service: ">=6.0.0 <12.0.0"
yaml: ^3.0.0
# matcher is tightly constrained by test_api
matcher: ^0.12.11
# Use an exact version until the test_api package is stable.
test_api: 0.5.3
test_api: 0.6.0

dev_dependencies:
lints: '>=1.0.0 <3.0.0'