Factor out a SuiteConfiguration object. #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tracks configuration that makes sense to apply to test suites, as opposed to Configuration which applies to an entire run and Metadata which applies to individual tests. This is intended to make it easier for load separate configurations for separate targets in a live test runner.
jmesserly
approved these changes
Nov 17, 2016
|
|
||
| var newPresets = new Map<String, Configuration>.from(presets); | ||
| var merged = chosenPresets.fold(empty, (merged, preset) { | ||
| if (!newPresets.containsKey(preset)) return merged; |
There was a problem hiding this comment.
if null isn't possible in presets, then you can combine these two operations in one dictionary lookup:
var newPreset = newPresets.remove(preset);
return newPreset != null ? merged.merge(newPreset) : merged;https://api.dartlang.org/stable/1.20.1/dart-core/Map/remove.html
whether it's worth a small tweak like that, not sure. :)
There was a problem hiding this comment.
All small tweaks are worth it if they're good. I can even make it cleaner, since Configuration.merge(Configuration.empty) is a no-op. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks configuration that makes sense to apply to test suites, as
opposed to Configuration which applies to an entire run and Metadata
which applies to individual tests. This is intended to make it easier
for load separate configurations for separate targets in a live test
runner.
@goderbauer