Replace "Future expect()" with "expectLater()". #546
Conversation
There was a problem hiding this comment.
LGTM
Not sure if we want to bikeshed on the name. I'm find with expectLater since I can't think of anything better (and I might have been the one that suggested it?) - but it is just a little clunky so we could ask some other folks to brainstorm. Good with me either way.
| @@ -11,6 +11,12 @@ import '../backend/invoker.dart'; | |||
| import '../utils.dart'; | |||
| import 'async_matcher.dart'; | |||
|
|
|||
| /// A future that emits `null`. | |||
| /// | |||
| /// We cache and re-use this value to avoid adding a new microtask hit for each | |||
There was a problem hiding this comment.
have we confirmed that this solves the flutter scenario?
Another pattern we could consider is to return null from _expect and always guarantee a Future from expectLater with something like => _expect(...) ?? _emptyFuture;
There was a problem hiding this comment.
Since we only instantiate this once, it definitely won't add more than one microtask unless it gets listeners. As long as they add something like setUpAll(() => expect(null, isNull)) it should work fine.
That said, while I'm hoping to mitigate the microtask-counting scenario, finding a surefire and highly usable solution isn't really a goal for me. The number of microtasks in the event queue at any given point is deep into "not guaranteed" territory.
No description provided.