Remove registerTestPlatform() #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the Loader is the canonical place for determining which TestPlatforms are valid, we no longer need a separate mechanism for registering platforms. Adding a plugin to the loader is sufficient. See #391
|
I fail to see how we will register a new platform in the loader. Can you give a small code snippet? |
loader.registerPlatformPlugin([
new TestPlatform("name", "identifier")
], () => new MyPlatformPlugin());Or, using the top-level hack API: registerPlatformPlugin([
new TestPlatform("name", "identifier")
], () => new MyPlatformPlugin()); |
grouma
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the Loader is the canonical place for determining which
TestPlatforms are valid, we no longer need a separate mechanism for
registering platforms. Adding a plugin to the loader is sufficient.
See #391