Skip to content

Remove registerTestPlatform()#695

Merged
nex3 merged 1 commit into
feature.flexible-test-platformsfrom
no-register-test-platform
Oct 4, 2017
Merged

Remove registerTestPlatform()#695
nex3 merged 1 commit into
feature.flexible-test-platformsfrom
no-register-test-platform

Conversation

@nex3

@nex3 nex3 commented Oct 4, 2017

Copy link
Copy Markdown
Member

Now that the Loader is the canonical place for determining which
TestPlatforms are valid, we no longer need a separate mechanism for
registering platforms. Adding a plugin to the loader is sufficient.

See #391

Now that the Loader is the canonical place for determining which
TestPlatforms are valid, we no longer need a separate mechanism for
registering platforms. Adding a plugin to the loader is sufficient.

See #391
@nex3
nex3 requested a review from grouma October 4, 2017 03:21
@grouma

grouma commented Oct 4, 2017

Copy link
Copy Markdown
Member

I fail to see how we will register a new platform in the loader. Can you give a small code snippet?

@nex3

nex3 commented Oct 4, 2017

Copy link
Copy Markdown
Member Author
loader.registerPlatformPlugin([
  new TestPlatform("name", "identifier")
], () => new MyPlatformPlugin());

Or, using the top-level hack API:

registerPlatformPlugin([
  new TestPlatform("name", "identifier")
], () => new MyPlatformPlugin());

@grouma grouma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh it's clear to me now. Thanks! LGTM

@nex3
nex3 merged commit 44cfc06 into feature.flexible-test-platforms Oct 4, 2017
@nex3
nex3 deleted the no-register-test-platform branch October 4, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants