Skip to content

Forbid define_platforms in the global config file #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2017
Merged

Forbid define_platforms in the global config file #701

merged 1 commit into from
Oct 17, 2017

Conversation

nex3
Copy link
Member

@nex3 nex3 commented Oct 16, 2017

No description provided.

@nex3 nex3 requested a review from grouma October 16, 2017 22:46
grouma
grouma approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you hit one of our elusive flakes :/ Take a look to see if you have thoughts on where the test stall can be coming from.

@nex3
Copy link
Member Author

nex3 commented Oct 16, 2017

That's tricky... the fact that it's not even updating the test run time suggests that something synchronous is deadlocking the main isolate, but it's hard to imagine what that would be. It's possible that it's some kind of pernicious VM issue.

@nex3 nex3 merged commit 0f63fbc into feature.flexible-test-platforms Oct 17, 2017
@grouma grouma deleted the forbid-define-platforms branch June 13, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grouma grouma grouma approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nex3 @grouma @googlebot