Skip to content

Save events locally, regardless of analytics opt-in status #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Save events locally, regardless of analytics opt-in status #11

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
db28a4e
adding event for analyzer startup
eliasyishak Feb 15, 2023
f83f19c
switching from hyphens to underscore; GA4 restriction
eliasyishak Feb 15, 2023
9d0dd2e
making eventData nullable for events that don't need it
eliasyishak Feb 15, 2023
f105267
Update dash_analytics_example.dart
eliasyishak Feb 15, 2023
9825399
added test to check for limitations below
eliasyishak Feb 15, 2023
2b26e92
Merge branch 'conforming-ga-limitations' into main
eliasyishak Feb 15, 2023
16ba932
Merge branch 'main' of https://github.com/eliasyishak/tools
eliasyishak Feb 17, 2023
24beebf
Check for telemetry status after saving locally
eliasyishak Feb 21, 2023
b16ffc5
Merge branch 'dart-lang:main' into main
eliasyishak Feb 22, 2023
2aeebe5
Merge branch 'dart-lang:main' into main
eliasyishak Feb 28, 2023
74838d1
Merge branch 'dart-lang:main' into main
eliasyishak Feb 28, 2023
a19d8bd
Empty commit
eliasyishak Feb 28, 2023
f35de81
Update enums.dart
eliasyishak Feb 28, 2023
034fa11
Merge branch 'dart-lang:main' into main
eliasyishak Feb 28, 2023
546b4b1
Merge branch 'dart-lang:main' into main
eliasyishak Mar 1, 2023
eee9570
Revert "Check for telemetry status after saving locally"
eliasyishak Mar 1, 2023
9f26c65
Merge pull request #4 from eliasyishak/main
eliasyishak Mar 1, 2023
68a831b
Save event data locally before checking telemetry status on sendEvent
eliasyishak Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/unified_analytics/lib/src/analytics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ class AnalyticsImpl implements Analytics {
required DashEvent eventName,
Map<String, Object?> eventData = const {},
}) {
if (!telemetryEnabled) return null;

// Construct the body of the request
final Map<String, Object?> body = generateRequestBody(
clientId: _clientId,
Expand All @@ -255,6 +253,8 @@ class AnalyticsImpl implements Analytics {

_logHandler.save(data: body);

if (!telemetryEnabled) return null;

// Pass to the google analytics client to send
return _gaClient.sendData(body);
}
Expand Down